Sign upLogin

ambertide/flask-verify

View on GitHub
Star

Showing 2 of 2 total issues

Function verify_json_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def verify_json_response(route: JSONRoute) -> Callable[..., Response]:
    """
    Verify that a Flask route returns a JSON Response.

    Effectively confirm the type of the Response by converting
Severity: Minor
Found in flask_verify/verify_json.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function verify_json_request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def verify_json_request(must_contain: Optional[Iterable] = None) -> Callable:
    """
    Verify that the Request's type is JSON and contains necessary keys.

    Verify that a request sent to a Flask route has a request
Severity: Minor
Found in flask_verify/verify_json.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language