Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/ork3/class.Treasury.php

Summary

Maintainability
D
3 days
Test Coverage

File class.Treasury.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Treasury extends Ork3 {

    public function __construct() {
Severity: Minor
Found in system/lib/ork3/class.Treasury.php - About 6 hrs to fix

    Treasury has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Treasury extends Ork3 {

    public function __construct() {
        parent::__construct();
        $this->split = new yapo($this->db, DB_PREFIX . 'split');
    Severity: Minor
    Found in system/lib/ork3/class.Treasury.php - About 3 hrs to fix

      Method DuesPaidToPark has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function DuesPaidToPark($request) {
        logtrace('DuesPaidToPark', $request);
        if (($player = Ork3::$Lib->player->player_info($request['MundaneId'])) === false)
            return InvalidParameter('Player could not be found.');
      Severity: Major
      Found in system/lib/ork3/class.Treasury.php - About 2 hrs to fix

        Method record_transaction has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function record_transaction($trn, $splits, $trx_date = null) {
        logtrace('record_transaction', array($trn, $splits, $trx_date));
        $trx_date = is_null($trx_date)?date('Y-m-d'):date('Y-m-d',strtotime($trx_date));
        $authority = false;
        foreach ($splits as $s => $split) {
        Severity: Major
        Found in system/lib/ork3/class.Treasury.php - About 2 hrs to fix

          Method create_accounts has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function create_accounts($mundane_id, $type, $id, $kingdom_id=0) {
        if ('park' == $type && $kingdom_id ==0) {
            return false;
        } else if ('park' == $type) {
            $pointers = $this->fetch_account_pointers('kingdom', $kingdom_id);
          Severity: Major
          Found in system/lib/ork3/class.Treasury.php - About 2 hrs to fix

            Function record_transaction has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function record_transaction($trn, $splits, $trx_date = null) {
        logtrace('record_transaction', array($trn, $splits, $trx_date));
        $trx_date = is_null($trx_date)?date('Y-m-d'):date('Y-m-d',strtotime($trx_date));
        $authority = false;
        foreach ($splits as $s => $split) {
            Severity: Minor
            Found in system/lib/ork3/class.Treasury.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create_account has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function create_account($mundane_id, $parent_id, $account_name, $account_type, $opening_balance, $owner_type, $owner_id, $kingdom_id=0) {
        if (!Ork3::$Lib->authorization->HasAuthority($mundane_id, ucfirst($owner_type), $owner_id, AUTH_CREATE)) return false;
        $owner = $owner_type . '_id';
        $this->account->clear();
        $this->account->kingdom_id = $kingdom_id;
            Severity: Minor
            Found in system/lib/ork3/class.Treasury.php - About 1 hr to fix

              Function DuesPaidToPark has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function DuesPaidToPark($request) {
        logtrace('DuesPaidToPark', $request);
        if (($player = Ork3::$Lib->player->player_info($request['MundaneId'])) === false)
            return InvalidParameter('Player could not be found.');
              Severity: Minor
              Found in system/lib/ork3/class.Treasury.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function create_accounts has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function create_accounts($mundane_id, $type, $id, $kingdom_id=0) {
        if ('park' == $type && $kingdom_id ==0) {
            return false;
        } else if ('park' == $type) {
            $pointers = $this->fetch_account_pointers('kingdom', $kingdom_id);
              Severity: Minor
              Found in system/lib/ork3/class.Treasury.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create_account has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function create_account($mundane_id, $parent_id, $account_name, $account_type, $opening_balance, $owner_type, $owner_id, $kingdom_id=0) {
              Severity: Major
              Found in system/lib/ork3/class.Treasury.php - About 1 hr to fix

                Avoid too many return statements within this method.
                Open

                                return InvalidParameter();
                Severity: Major
                Found in system/lib/ork3/class.Treasury.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return NoAuthorization('You lack authoratah.');
                  Severity: Major
                  Found in system/lib/ork3/class.Treasury.php - About 30 mins to fix

                    Function DetermineAuthType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function DetermineAuthType() {
        $type = 'None';
        $id = 0;
        if ($this->account->park_id > 0) { $type = AUTH_PARK; $id = $this->account->park_id; };
        if ($this->account->event_id > 0) { $type = AUTH_EVENT; $id = $this->account->event_id; };
                    Severity: Minor
                    Found in system/lib/ork3/class.Treasury.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function __construct() {
        parent::__construct();
        $this->split = new yapo($this->db, DB_PREFIX . 'split');
        $this->account = new yapo($this->db, DB_PREFIX . 'account');
        $this->transaction = new yapo($this->db, DB_PREFIX . 'transaction');
                    Severity: Minor
                    Found in system/lib/ork3/class.Treasury.php and 1 other location - About 45 mins to fix
                    system/lib/ork3/class.Game.php on lines 5..10

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 95.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status