Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/yapo/class.yapo.php

Summary

Maintainability
F
1 wk
Test Coverage

Function find has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    public function find($order_by=null, $conjunction='AND', $limit = null, $showsql = false) {
        $search_terms = array();
        $clause_terms = array();
        /*
            Package up all the clauses that must be bundled together in the WHERE statement
Severity: Minor
Found in system/lib/yapo/class.yapo.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File class.yapo.php has 397 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

require_once('class.yapo_mysql.php');

/* */
Severity: Minor
Found in system/lib/yapo/class.yapo.php - About 5 hrs to fix

    Function delete has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

        public function delete() {
        $primaryKey = $this->__primary_key;
        if (is_null($this->$primaryKey)) { // delete a set
            //echo "set deletion not supported yet";
            $search_terms = array();
    Severity: Minor
    Found in system/lib/yapo/class.yapo.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    yapo has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class yapo {
    private $__database;
    private $__fields = array();
    private $__primary_key;
    private $__table;
    Severity: Minor
    Found in system/lib/yapo/class.yapo.php - About 3 hrs to fix

      Method find has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function find($order_by=null, $conjunction='AND', $limit = null, $showsql = false) {
        $search_terms = array();
        $clause_terms = array();
        /*
            Package up all the clauses that must be bundled together in the WHERE statement
      Severity: Major
      Found in system/lib/yapo/class.yapo.php - About 3 hrs to fix

        Method delete has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function delete() {
        $primaryKey = $this->__primary_key;
        if (is_null($this->$primaryKey)) { // delete a set
            //echo "set deletion not supported yet";
            $search_terms = array();
        Severity: Minor
        Found in system/lib/yapo/class.yapo.php - About 1 hr to fix

          Function get_dirty_fields has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function get_dirty_fields($include_primary = true) {
        $dirty_fields = array();
        foreach ($this->__fields as $field => $value) {
            if ($this->$field != $this->htmldec($value)) {
                if ($include_primary) {
          Severity: Minor
          Found in system/lib/yapo/class.yapo.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method save has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function save() {
        $primaryKey = $this->__primary_key;
        if (is_null($this->$primaryKey)) { // insert new
            $values = array();
            foreach ($this->__fields as $field => $value) {
          Severity: Minor
          Found in system/lib/yapo/class.yapo.php - About 1 hr to fix

            Function save has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function save() {
        $primaryKey = $this->__primary_key;
        if (is_null($this->$primaryKey)) { // insert new
            $values = array();
            foreach ($this->__fields as $field => $value) {
            Severity: Minor
            Found in system/lib/yapo/class.yapo.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_html has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function get_html($lvl=1) {
        $html;
        if ($this->__relationship) {
            $html = "<h$lvl>$this->__table as ".$this->get_alias()."</h$lvl>";
        } else {
            Severity: Minor
            Found in system/lib/yapo/class.yapo.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_tables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function get_tables() {
        $table_list = array();
        foreach ($this->__one as $table => $local_key) {
            if ($this->$table->is_aggressive()) {
                $table_list[$this->$table->get_alias()] = $local_key;
            Severity: Minor
            Found in system/lib/yapo/class.yapo.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_fields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function get_fields() {
        $field_list = array();
        foreach ($this->__one as $table => $local_key) {
            if ($this->$table->is_aggressive()) {
                $field_list = array_merge($field_list, $this->$table->get_fields());
            Severity: Minor
            Found in system/lib/yapo/class.yapo.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        foreach ($this->__fields as $field => $value) {
                if (isset($clause_terms[$field])) continue;
                if ($this->$field != $this->htmldec($value)) {
                    $search_terms[$field] = array('value' => $this->s_prep($this->htmldec($this->$field)), 'term' => '=' );
                } else if (!is_null($this->$field) && is_null($value)) {
            Severity: Major
            Found in system/lib/yapo/class.yapo.php and 1 other location - About 1 day to fix
            system/lib/yapo/class.yapo.php on lines 227..247

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 274.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($this->__fields as $field => $value) {
            if (isset($clause_terms[$field])) continue;
            if ($this->$field != $this->htmldec($value)) {
                $search_terms[$field] = array('value' => $this->s_prep($this->htmldec($this->$field)), 'term' => '=' );
            } else if (!is_null($this->$field) && is_null($value)) {
            Severity: Major
            Found in system/lib/yapo/class.yapo.php and 1 other location - About 1 day to fix
            system/lib/yapo/class.yapo.php on lines 39..59

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 274.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (is_array($clause_terms)) foreach($clause_terms as $field => $value) {
                $first_conjunction = array_slice($value,0,1);
                $first_clause_key = array_keys($first_conjunction);
                $first_conjunction = $first_conjunction[$first_clause_key[0]]['conjunction'];
                $search_terms[$field] = array('clause' => ' ('.substr(implode(" ",array_map(array('yapo','map_search_terms'),array_keys($value),$value)), strlen($first_conjunction) + 1).') ');
            Severity: Major
            Found in system/lib/yapo/class.yapo.php and 1 other location - About 4 hrs to fix
            system/lib/yapo/class.yapo.php on lines 217..225

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach($clause_terms as $field => $value) {
            $first_conjunction = array_slice($value,0,1);
            $first_clause_key = array_keys($first_conjunction);
            $first_conjunction = $first_conjunction[$first_clause_key[0]]['conjunction'];
            $search_terms[$field] = array('clause' => ' ('.substr(implode(" ",array_map(array('yapo','map_search_terms'),array_keys($value),$value)), strlen($first_conjunction) + 1).') ');
            Severity: Major
            Found in system/lib/yapo/class.yapo.php and 1 other location - About 4 hrs to fix
            system/lib/yapo/class.yapo.php on lines 29..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status