andela/team-odd-bn-backend

View on GitHub

Showing 137 of 137 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    comments.associate = function (models) {
        comments.belongsTo(models.users, {
            foreignKey: 'userId',
            onDelete: 'CASCADE',
            onUpdate: 'CASCADE',
Severity: Major
Found in src/database/models/comments.js and 1 other location - About 2 hrs to fix
src/database/models/likes.js on lines 9..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getUserBookingReqService has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static async getUserBookingReqService(req) {
    const { bookingId: id } = req.params;
    const managerObj = {
      where: { managerId: req.user.id }
    };
Severity: Major
Found in src/services/BookingService.js - About 2 hrs to fix

    Function exports has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (sequelize, DataTypes) => {
      const users = sequelize.define(
        'users',
        {
          firstName: DataTypes.STRING,
    Severity: Major
    Found in src/database/models/user.js - About 2 hrs to fix

      Function forgotPasswordTemplate has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static forgotPasswordTemplate(req, user) {
          const token = AuthenticateToken.signToken(user.dataValues);
      
          const appUrl = `${req.protocol}://${req.headers.host}`;
          return {
      Severity: Major
      Found in src/helpers/EmailTemplates.js - About 2 hrs to fix

        Function up has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          up: (queryInterface, Sequelize) => {
            return queryInterface.bulkInsert('accommodations', [
              {
                name: 'serena hotel',
                cityId: 3,
        Severity: Major
        Found in src/database/seeders/20191105144530-accommodations.js - About 2 hrs to fix

          Function up has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            up: (queryInterface, Sequelize) => {
              return queryInterface.createTable('notifications', {
                id: {
                  allowNull: false,
                  autoIncrement: true,
          Severity: Major
          Found in src/database/migrations/20191203223954-create-notifications.js - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const checkInputDataError = (req, res, next) => {
              const errors = validationResult(req);
              if (!errors.isEmpty()) {
                const errorMessage = errors.errors.map(err => err.msg);
                return Response.errorMessage(req, res, errorMessage, 400);
            Severity: Major
            Found in src/middlewares/checkInputDataError.js and 1 other location - About 2 hrs to fix
            src/middlewares/ForgotPasswordMiddlewares.js on lines 18..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              static checkForgotPasswordMiddleware(req, res, next) {
                const error = validationResult(req);
                if (!error.isEmpty()) {
                  const err = error.errors.map(err => err.msg);
                  return Response.errorMessage(req, res, err, 400);
            Severity: Major
            Found in src/middlewares/ForgotPasswordMiddlewares.js and 1 other location - About 2 hrs to fix
            src/middlewares/checkInputDataError.js on lines 4..11

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File TripService.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import Sequelize, { Promise } from 'sequelize';
            import {
              tripRequests, trips, userProfile, users, accommodations, cities, tripTypes, status
            } from '../database/models';
            import TripHelper from '../helpers/TripHelper';
            Severity: Minor
            Found in src/services/TripService.js - About 2 hrs to fix

              Function up has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                up: (queryInterface, Sequelize) => {
                  return queryInterface.createTable('trips', {
                    id: {
                      allowNull: false,
                      autoIncrement: true,
              Severity: Major
              Found in src/database/migrations/20191119162259-create-trips.js - About 2 hrs to fix

                Function updateProfile has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  static async updateProfile(req) {
                    const { id } = req.user;
                    const userObject = {
                      where: {
                        id
                Severity: Major
                Found in src/services/UserService.js - About 2 hrs to fix

                  Function up has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    up: (queryInterface, Sequelize) => {
                      return queryInterface.createTable('userProfile', {
                        id: {
                          allowNull: false,
                          autoIncrement: true,
                  Severity: Major
                  Found in src/database/migrations/20191115165558-create-user-profile.js - About 2 hrs to fix

                    Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = (sequelize, DataTypes) => {
                      const accommodations = sequelize.define('accommodations', {
                        userId: DataTypes.INTEGER,
                        name: DataTypes.STRING,
                        userId: DataTypes.INTEGER,
                    Severity: Major
                    Found in src/database/models/accommodations.js - About 2 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        static async createNewRating(req, res) {
                          try {
                            const result = await createNewRating(req);
                            return Response.successMessage(req, res, 'You have successfully rated this accomodation', result, 201);
                          } catch (err) {
                      Severity: Major
                      Found in src/controllers/AccommodationController.js and 1 other location - About 1 hr to fix
                      src/controllers/TripController.js on lines 61..68

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 74.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        static async getUserRequests(req, res) {
                          try {
                            const requests = await getUserRequests(req);
                            return Response.successMessage(req, res, 'succesfully fetched all  user\'s requests', requests, 200);
                          } catch (err) {
                      Severity: Major
                      Found in src/controllers/TripController.js and 1 other location - About 1 hr to fix
                      src/controllers/AccommodationController.js on lines 20..27

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 74.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function getAccommodations has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        static async getAccommodations(req) {
                          const getAccommodationsQueryObject = req.params.accommodationId
                            ? {
                              where: { id: req.params.accommodationId },
                              include: [{
                      Severity: Minor
                      Found in src/services/AccommodationService.js - About 1 hr to fix

                        Function addAccommodationLike has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          static async addAccommodationLike(req) {
                            let setObject, displayMessage;
                            let { like } = req.query;
                            const { accommodationId } = req.params;
                            const { id } = req.user;
                        Severity: Minor
                        Found in src/services/AccommodationService.js - About 1 hr to fix

                          Function up has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            up: (queryInterface, Sequelize) => {
                              return queryInterface.bulkInsert('users', [
                                {
                                  firstName: 'John',
                                  lastName: 'Doe',
                          Severity: Minor
                          Found in src/database/seeders/20191104145912-users.js - About 1 hr to fix

                            Function availtripRequestsToManager has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              static async availtripRequestsToManager(id) {
                                const userObj = {
                                  where: { managerId: id },
                                  attributes: ['userId'],
                                  raw: true
                            Severity: Minor
                            Found in src/services/TripService.js - About 1 hr to fix

                              Function up has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                up: (queryInterface, Sequelize) => {
                                  return queryInterface.createTable('likes', {
                                    id: {
                                      allowNull: false,
                                      autoIncrement: true,
                              Severity: Minor
                              Found in src/database/migrations/20191203152322-create-likes.js - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language