Showing 137 of 137 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
comments.associate = function (models) {
comments.belongsTo(models.users, {
foreignKey: 'userId',
onDelete: 'CASCADE',
onUpdate: 'CASCADE',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 81.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function getUserBookingReqService
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
static async getUserBookingReqService(req) {
const { bookingId: id } = req.params;
const managerObj = {
where: { managerId: req.user.id }
};
Function exports
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = (sequelize, DataTypes) => {
const users = sequelize.define(
'users',
{
firstName: DataTypes.STRING,
Function forgotPasswordTemplate
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
static forgotPasswordTemplate(req, user) {
const token = AuthenticateToken.signToken(user.dataValues);
const appUrl = `${req.protocol}://${req.headers.host}`;
return {
Function up
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
up: (queryInterface, Sequelize) => {
return queryInterface.bulkInsert('accommodations', [
{
name: 'serena hotel',
cityId: 3,
Function up
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
up: (queryInterface, Sequelize) => {
return queryInterface.createTable('notifications', {
id: {
allowNull: false,
autoIncrement: true,
Similar blocks of code found in 2 locations. Consider refactoring. Open
const checkInputDataError = (req, res, next) => {
const errors = validationResult(req);
if (!errors.isEmpty()) {
const errorMessage = errors.errors.map(err => err.msg);
return Response.errorMessage(req, res, errorMessage, 400);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 78.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
static checkForgotPasswordMiddleware(req, res, next) {
const error = validationResult(req);
if (!error.isEmpty()) {
const err = error.errors.map(err => err.msg);
return Response.errorMessage(req, res, err, 400);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 78.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
File TripService.js
has 256 lines of code (exceeds 250 allowed). Consider refactoring. Open
import Sequelize, { Promise } from 'sequelize';
import {
tripRequests, trips, userProfile, users, accommodations, cities, tripTypes, status
} from '../database/models';
import TripHelper from '../helpers/TripHelper';
Function up
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
up: (queryInterface, Sequelize) => {
return queryInterface.createTable('trips', {
id: {
allowNull: false,
autoIncrement: true,
Function updateProfile
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
static async updateProfile(req) {
const { id } = req.user;
const userObject = {
where: {
id
Function up
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
up: (queryInterface, Sequelize) => {
return queryInterface.createTable('userProfile', {
id: {
allowNull: false,
autoIncrement: true,
Function exports
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = (sequelize, DataTypes) => {
const accommodations = sequelize.define('accommodations', {
userId: DataTypes.INTEGER,
name: DataTypes.STRING,
userId: DataTypes.INTEGER,
Similar blocks of code found in 2 locations. Consider refactoring. Open
static async createNewRating(req, res) {
try {
const result = await createNewRating(req);
return Response.successMessage(req, res, 'You have successfully rated this accomodation', result, 201);
} catch (err) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 74.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
static async getUserRequests(req, res) {
try {
const requests = await getUserRequests(req);
return Response.successMessage(req, res, 'succesfully fetched all user\'s requests', requests, 200);
} catch (err) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 74.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function getAccommodations
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
static async getAccommodations(req) {
const getAccommodationsQueryObject = req.params.accommodationId
? {
where: { id: req.params.accommodationId },
include: [{
Function addAccommodationLike
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
static async addAccommodationLike(req) {
let setObject, displayMessage;
let { like } = req.query;
const { accommodationId } = req.params;
const { id } = req.user;
Function up
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
up: (queryInterface, Sequelize) => {
return queryInterface.bulkInsert('users', [
{
firstName: 'John',
lastName: 'Doe',
Function availtripRequestsToManager
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
static async availtripRequestsToManager(id) {
const userObj = {
where: { managerId: id },
attributes: ['userId'],
raw: true
Function up
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
up: (queryInterface, Sequelize) => {
return queryInterface.createTable('likes', {
id: {
allowNull: false,
autoIncrement: true,