andela/team-odd-bn-backend

Similar blocks of code found in 4 locations. Consider refactoring.

Open

  static async isTravelAdministrator(req, res, next) {
    const dbRoleId = await UserHelper.userRoleType(req, roles);
    if (dbRoleId !== 4) {
      return Response.errorMessage(req, res, 'you are not a travel administrator', 403);
    }

• Read up
  Read up

Function socialCallBack has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async socialCallBack(accessToken, refreshToken, profile, signupTypeParameter, done) {
    try {
      const data = {
        id: profile.id,
        firstName: profile.name.givenName,

Function editTripRequestToUser has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async editTripRequestToUser(req) {
    const itinerary = req.body.itinerary ? req.body.itinerary : [req.body];

    const findAllObjQuery = {
      attributes: ['id'],

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    try {
      const result = await LocationService.getLocations();
      if (result.length === 0) {
        return Response.errorMessage(req, res, 'No city is available at the moment', 404);
      }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static async availableUsers(req, res) {
    const allUsers = await UserService.availableUsers();
    if (allUsers.length === 0) {
      return Response.errorMessage(req, res, 'no users are available', 404);
    }

• Read up
  Read up

Function addCommentNotification has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async addCommentNotification(req) {
    const { user, params } = req;
    const tripRequestInfoObject = {
      where: {
        id: params.tripRequestId

Function getSingleTrip has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async getSingleTrip(tripRequestId) {
    const singleTripObject = {
      where: { id: tripRequestId },
      include: [
        {

Function managerRequests has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    let managerRequests = managerUsers.map(async user => {
      const managerRequestsObj = {
        where: { userId: user.userId, statusId: 1 },
        attributes: ['id', 'updatedAt', 'createdAt'],
        order: [

Function bookAccommodationService has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async bookAccommodationService(req, res) {
    try {
      const accommodationObj = {
        raw: true
      };

Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

module.exports = (sequelize, DataTypes) => {
  const tripRequests = sequelize.define('tripRequests', {
    userId: DataTypes.INTEGER,
    tripTypeId: DataTypes.INTEGER,
    statusId: DataTypes.STRING,

Function up has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  up: (queryInterface, Sequelize) => {
    return queryInterface.bulkInsert('users', [{
        firstName: 'John',
        lastName: 'Doe',
        email: 'admin@gmail.com',

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static async getSpecificComments(req) {
    const { commentId } = req.params;
    const queryObj = {
      where: {
        commentId,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static async deleteComment(req) {
    const { commentId } = req.params;
    const queryObject = {
      where: {
        id: commentId,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    const allCitiess = await trips.findAll({
      include: [{
        model: tripRequests,
        where: { userId: req.user.id, statusId: 1 }
      }],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static async createNewAccomodation(req, res) {
    try {
      const newAccommodation = await createAccomodation(req);
      return Response.successMessage(req, res, 'Accommodation successfully posted', newAccommodation, 201);
    } catch (err) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    const allCitiess = await trips.findAll({
      include: [{
        model: tripRequests,
        where: { userId: req.user.id, statusId: 1 }
      }],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static async getAccommodations(req, res) {
    try {
      const accommodations = await getAccommodations(req);
      return Response.successMessage(req, res, 'Accommodation(s) successfully fetched', accommodations, 200);
    } catch (err) {

• Read up
  Read up

Function checkForSimilarRequests has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async checkForSimilarRequests(req, res, next) {
    const itinerary = req.body.itinerary ? req.body.itinerary : [req.body];

    const allCitiess = await trips.findAll({
      include: [{

Function up has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  up: (queryInterface, Sequelize) => {
    return queryInterface.createTable('rooms', {
      id: {
        allowNull: false,
        autoIncrement: true,

Function validateSearchQueries has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const validateSearchQueries = (req, res, next) => {
  const { query } = req;
  const allKeys = Object.keys(query);
  if (allKeys.length === 0) {
    return Response.errorMessage(req, res, 'Please provide a search query key parameter', 400);