Sign upLogin

anexia-it/k8s-anexia-ccm

View on GitHub
Star
anx/provider/loadbalancer/loadbalancer.go

Summary

Maintainability
B
4 hrs
Test Coverage
F
10%

Method mgr.reconciliationForService has 77 lines of code (exceeds 50 allowed). Consider refactoring.
Confirmed

func (m mgr) reconciliationForService(ctx context.Context, clusterName string, svc *v1.Service, nodes []*v1.Node) (reconciliation.Reconciliation, []net.IP, error) {
    var ports map[string]reconciliation.Port
    var servers []reconciliation.Server
    var externalAddresses []net.IP
Severity: Major
Found in anx/provider/loadbalancer/loadbalancer.go - About 2 hrs to fix

    Method mgr.reconciliationForService has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Confirmed

    func (m mgr) reconciliationForService(ctx context.Context, clusterName string, svc *v1.Service, nodes []*v1.Node) (reconciliation.Reconciliation, []net.IP, error) {
    var ports map[string]reconciliation.Port
    var servers []reconciliation.Server
    var externalAddresses []net.IP
    Severity: Minor
    Found in anx/provider/loadbalancer/loadbalancer.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function New has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Confirmed

    func New(config *configuration.ProviderConfig, logger logr.Logger, k8sClient kubernetes.Interface, apiClient api.API, legacyClient client.Client, providerMetrics metrics.ProviderMetrics) (cloudprovider.LoadBalancer, error) {
    Severity: Minor
    Found in anx/provider/loadbalancer/loadbalancer.go - About 45 mins to fix

      Method mgr.reconciliationForService has 6 return statements (exceeds 4 allowed).
      Confirmed

      func (m mgr) reconciliationForService(ctx context.Context, clusterName string, svc *v1.Service, nodes []*v1.Node) (reconciliation.Reconciliation, []net.IP, error) {
    var ports map[string]reconciliation.Port
    var servers []reconciliation.Server
    var externalAddresses []net.IP
      Severity: Major
      Found in anx/provider/loadbalancer/loadbalancer.go - About 40 mins to fix

        XXX found
        Confirmed

            // XXX: assumes a node has one internal and one external IP, does funny things when a nodes has multiple of a given type
        Severity: Minor
        Found in anx/provider/loadbalancer/loadbalancer.go by fixme

        TODO found
        Invalid

            ctx := logr.NewContext(context.TODO(), logger)
        Severity: Minor
        Found in anx/provider/loadbalancer/loadbalancer.go by fixme

        There are no issues that match your filters.

        Category
        Status