Method reconciliation.Reconcile has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.

Confirmed

func (r *reconciliation) Reconcile() error {
    completed := false

    for !completed {
        startTimeTotal := time.Now()

• Read up
  Read up

Method reconciliation.retrieveResources has 87 lines of code (exceeds 50 allowed). Consider refactoring.

Confirmed

func (r *reconciliation) retrieveResources() error {
    ctx, cancel := context.WithCancel(r.ctx)
    defer cancel()

    var oc types.ObjectChannel

Method mgr.reconciliationForService has 77 lines of code (exceeds 50 allowed). Consider refactoring.

Confirmed

func (m mgr) reconciliationForService(ctx context.Context, clusterName string, svc *v1.Service, nodes []*v1.Node) (reconciliation.Reconciliation, []net.IP, error) {
    var ports map[string]reconciliation.Port
    var servers []reconciliation.Server
    var externalAddresses []net.IP

Method reconciliation.Reconcile has 74 lines of code (exceeds 50 allowed). Consider refactoring.

Confirmed

func (r *reconciliation) Reconcile() error {
    completed := false

    for !completed {
        startTimeTotal := time.Now()

Function New has 10 arguments (exceeds 4 allowed). Consider refactoring.

Confirmed

    ctx context.Context,
    apiClient api.API,

    resourceNameSuffix string,
    loadBalancerIdentifier string,

Method mgr.reconciliationForService has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.

Confirmed

func (m mgr) reconciliationForService(ctx context.Context, clusterName string, svc *v1.Service, nodes []*v1.Node) (reconciliation.Reconciliation, []net.IP, error) {
    var ports map[string]reconciliation.Port
    var servers []reconciliation.Server
    var externalAddresses []net.IP

• Read up
  Read up

Method reconciliation.retrieveResources has 11 return statements (exceeds 4 allowed).

Confirmed

func (r *reconciliation) retrieveResources() error {
    ctx, cancel := context.WithCancel(r.ctx)
    defer cancel()

    var oc types.ObjectChannel

Method reconciliation.retrieveResources has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.

Confirmed

func (r *reconciliation) retrieveResources() error {
    ctx, cancel := context.WithCancel(r.ctx)
    defer cancel()

    var oc types.ObjectChannel

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        frontendResourceTypeIdentifier: func(identifier string) (err error) {
            frontend := &lbaasv1.Frontend{Identifier: identifier}
            if err = r.api.Get(ctx, frontend); err == nil && frontend.LoadBalancer.Identifier == r.lb.Identifier {
                r.frontends = append(r.frontends, frontend)
                r.sortObjectIntoStateArray(frontend)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        backendResourceTypeIdentifier: func(identifier string) (err error) {
            backend := &lbaasv1.Backend{Identifier: identifier}
            if err = r.api.Get(ctx, backend); err == nil && backend.LoadBalancer.Identifier == r.lb.Identifier {
                r.backends = append(r.backends, backend)
                r.sortObjectIntoStateArray(backend)

• Read up
  Read up

Function mergeReconStatus has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.

Confirmed

func mergeReconStatus(status []map[string][]uint16) map[string][]uint16 {
    addressPortReturnedCount := make(map[string]map[uint16]int)

    // first track number of status having a address-port-combination
    for _, s := range status {

• Read up
  Read up

Method reconciliation.Reconcile has 7 return statements (exceeds 4 allowed).

Confirmed

func (r *reconciliation) Reconcile() error {
    completed := false

    for !completed {
        startTimeTotal := time.Now()

Function New has 6 arguments (exceeds 4 allowed). Consider refactoring.

Confirmed

func New(config *configuration.ProviderConfig, logger logr.Logger, k8sClient kubernetes.Interface, apiClient api.API, legacyClient client.Client, providerMetrics metrics.ProviderMetrics) (cloudprovider.LoadBalancer, error) {

Method mgr.reconciliationForService has 6 return statements (exceeds 4 allowed).

Confirmed

func (m mgr) reconciliationForService(ctx context.Context, clusterName string, svc *v1.Service, nodes []*v1.Node) (reconciliation.Reconciliation, []net.IP, error) {
    var ports map[string]reconciliation.Port
    var servers []reconciliation.Server
    var externalAddresses []net.IP

Function newPrefix has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func newPrefix(ctx context.Context, apiclient api.API, ipamClient ipam.API, identifier string, autoDiscoveryName *string) (*prefix, error) {

Method instanceManager.InstanceExists has 5 return statements (exceeds 4 allowed).

Confirmed

func (i *instanceManager) InstanceExists(ctx context.Context, node *v1.Node) (bool, error) {
    if i.lastUnauthorizedOrForbiddenInstanceExistCall.Add(time.Minute).After(time.Now()) {
        return false, utils.ErrUnauthorizedForbiddenBackoff
    }

Method reconciliation.ReconcileCheck has 5 return statements (exceeds 4 allowed).

Open

func (r *reconciliation) ReconcileCheck() ([]types.Object, []types.Object, error) {
    if err := r.retrieveState(); err != nil {
        return nil, nil, fmt.Errorf("error retrieving current state for reconciliation: %w", err)
    }

2: cannot find package "github.com/kelseyhightower/envconfig" in any of:

Open

    "github.com/kelseyhightower/envconfig"

• Exclude checks
  • Disable engine
  • Disable check

XXX found

Confirmed

    // XXX: replace this with IPAM address allocation logic once we can add and remove LoadBalancer IPs

• Exclude checks
  • Disable engine
  • Disable check

XXX found

Confirmed

    // XXX: assumes a node has one internal and one external IP, does funny things when a nodes has multiple of a given type

• Exclude checks
  • Disable engine
  • Disable check