Sign upLogin

anexia-it/k8s-anexia-ccm

View on GitHub
Star
anx/provider/loadbalancer/reconciliation/reconciliation.go

Summary

Maintainability
D
1 day
Test Coverage
C
72%

Method reconciliation.Reconcile has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Confirmed

func (r *reconciliation) Reconcile() error {
    completed := false

    for !completed {
        startTimeTotal := time.Now()
Severity: Minor
Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reconciliation.retrieveResources has 87 lines of code (exceeds 50 allowed). Consider refactoring.
Confirmed

func (r *reconciliation) retrieveResources() error {
    ctx, cancel := context.WithCancel(r.ctx)
    defer cancel()

    var oc types.ObjectChannel
Severity: Major
Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 2 hrs to fix

    Method reconciliation.Reconcile has 74 lines of code (exceeds 50 allowed). Consider refactoring.
    Confirmed

    func (r *reconciliation) Reconcile() error {
    completed := false

    for !completed {
        startTimeTotal := time.Now()
    Severity: Minor
    Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 1 hr to fix

      Function New has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Confirmed

          ctx context.Context,
    apiClient api.API,

    resourceNameSuffix string,
    loadBalancerIdentifier string,
      Severity: Major
      Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 1 hr to fix

        Method reconciliation.retrieveResources has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
        Confirmed

        func (r *reconciliation) retrieveResources() error {
    ctx, cancel := context.WithCancel(r.ctx)
    defer cancel()

    var oc types.ObjectChannel
        Severity: Minor
        Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method reconciliation.retrieveResources has 11 return statements (exceeds 4 allowed).
        Confirmed

        func (r *reconciliation) retrieveResources() error {
    ctx, cancel := context.WithCancel(r.ctx)
    defer cancel()

    var oc types.ObjectChannel
        Severity: Major
        Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 1 hr to fix

          Method reconciliation.Reconcile has 7 return statements (exceeds 4 allowed).
          Confirmed

          func (r *reconciliation) Reconcile() error {
    completed := false

    for !completed {
        startTimeTotal := time.Now()
          Severity: Major
          Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 45 mins to fix

            Method reconciliation.ReconcileCheck has 5 return statements (exceeds 4 allowed).
            Open

            func (r *reconciliation) ReconcileCheck() ([]types.Object, []types.Object, error) {
    if err := r.retrieveState(); err != nil {
        return nil, nil, fmt.Errorf("error retrieving current state for reconciliation: %w", err)
    }
            Severity: Major
            Found in anx/provider/loadbalancer/reconciliation/reconciliation.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      backendResourceTypeIdentifier: func(identifier string) (err error) {
            backend := &lbaasv1.Backend{Identifier: identifier}
            if err = r.api.Get(ctx, backend); err == nil && backend.LoadBalancer.Identifier == r.lb.Identifier {
                r.backends = append(r.backends, backend)
                r.sortObjectIntoStateArray(backend)
              Severity: Minor
              Found in anx/provider/loadbalancer/reconciliation/reconciliation.go and 1 other location - About 1 hr to fix
              anx/provider/loadbalancer/reconciliation/reconciliation.go on lines 471..478

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 128.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      frontendResourceTypeIdentifier: func(identifier string) (err error) {
            frontend := &lbaasv1.Frontend{Identifier: identifier}
            if err = r.api.Get(ctx, frontend); err == nil && frontend.LoadBalancer.Identifier == r.lb.Identifier {
                r.frontends = append(r.frontends, frontend)
                r.sortObjectIntoStateArray(frontend)
              Severity: Minor
              Found in anx/provider/loadbalancer/reconciliation/reconciliation.go and 1 other location - About 1 hr to fix
              anx/provider/loadbalancer/reconciliation/reconciliation.go on lines 480..487

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 128.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status