Sign upLogin

angular/angular-hint

View on GitHub
Star

Showing 90 of 90 total issues

Function bindJQuery has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

function bindJQuery() {
  var originalCleanData;

  if (bindJQueryFired) {
    return;
Severity: Minor
Found in src/lib/debug-parse.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  logicalAND: function() {
    var left = this.equality();
    var token;
    while ((token = this.expect('&&'))) {
      left = this.binaryFn(left, token.text, this.equality(), true);
Severity: Major
Found in src/lib/debug-parse.js and 1 other location - About 2 hrs to fix
src/lib/debug-parse.js on lines 1822..1829

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  logicalOR: function() {
    var left = this.logicalAND();
    var token;
    while ((token = this.expect('||'))) {
      left = this.binaryFn(left, token.text, this.logicalAND(), true);
Severity: Major
Found in src/lib/debug-parse.js and 1 other location - About 2 hrs to fix
src/lib/debug-parse.js on lines 1831..1838

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function statements has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  statements: function() {
    var statements = [];
    while (true) {
      if (this.tokens.length > 0 && !this.peek('}', ')', ';', ']'))
        statements.push(this.filterChain());
Severity: Minor
Found in src/lib/debug-parse.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readNumber has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  readNumber: function() {
    var number = '';
    var start = this.index;
    while (this.index < this.text.length) {
      var ch = lowercase(this.text.charAt(this.index));
Severity: Minor
Found in src/lib/debug-parse.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readString has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  readString: function(quote) {
    var start = this.index;
    this.index++;
    var string = '';
    var rawString = quote;
Severity: Minor
Found in src/lib/debug-parse.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function object has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  object: function() {
    var keys = [], valueFns = [];
    if (this.peekToken().text !== '}') {
      do {
        if (this.peek('}')) {
Severity: Minor
Found in src/lib/debug-parse.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function equals has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function equals(o1, o2) {
  if (o1 === o2) return true;
  if (o1 === null || o2 === null) return false;
  if (o1 !== o1 && o2 !== o2) return true; // NaN === NaN
  var t1 = typeof o1, t2 = typeof o2, length, key, keySet;
Severity: Minor
Found in src/lib/debug-parse.js - About 1 hr to fix

    Function readString has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      readString: function(quote) {
    var start = this.index;
    this.index++;
    var string = '';
    var rawString = quote;
    Severity: Minor
    Found in src/lib/debug-parse.js - About 1 hr to fix

      Function primary has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        primary: function() {
    var primary;
    if (this.expect('(')) {
      primary = this.filterChain();
      this.consume(')');
      Severity: Minor
      Found in src/lib/debug-parse.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function bindJQuery has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function bindJQuery() {
  var originalCleanData;

  if (bindJQueryFired) {
    return;
      Severity: Minor
      Found in src/lib/debug-parse.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

              if (t === e1 || t === e2 || t === e3 || t === e4 ||
          (!e1 && !e2 && !e3 && !e4)) {
        return token;
      }
        Severity: Critical
        Found in src/lib/debug-parse.js - About 1 hr to fix

          Function inputsWatchDelegate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function inputsWatchDelegate(scope, listener, objectEquality, parsedExpression) {
      var inputExpressions = parsedExpression.$$inputs ||
                    (parsedExpression.$$inputs = collectExpressionInputs(parsedExpression.inputs, []));

      var lastResult;
          Severity: Minor
          Found in src/lib/debug-parse.js - About 1 hr to fix

            Function cspSafeGetterFn has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function cspSafeGetterFn(key0, key1, key2, key3, key4, fullExp, expensiveChecks) {
  ensureSafeMemberName(key0, fullExp);
  ensureSafeMemberName(key1, fullExp);
  ensureSafeMemberName(key2, fullExp);
  ensureSafeMemberName(key3, fullExp);
            Severity: Minor
            Found in src/lib/debug-parse.js - About 1 hr to fix

              Function $parse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  return function $parse(exp, interceptorFn, expensiveChecks) {
      var parsedExpression, oneTime, cacheKey;

      switch (typeof exp) {
        case 'string':
              Severity: Minor
              Found in src/lib/debug-parse.js - About 1 hr to fix

                Function $watch has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  scopePrototype.$watch = function (watchExpression, reactionFunction) {
    // Convert the `watchExpression` to a function (if not already one).
    // This is also the first thing `Scope.$watch()` does.
    var parsedExpression = $parse(watchExpression);
                Severity: Minor
                Found in src/modules/scopes.js - About 1 hr to fix

                  Function ngEventDirectivesDecorator has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function ngEventDirectivesDecorator(ngEventAttrName) {
  return function ($delegate, $parse) {
    var originalCompileFn = $delegate[0].compile;

    $delegate[0].compile = function(element, attrs, transclude) {
                  Severity: Minor
                  Found in src/modules/events.js - About 1 hr to fix

                    Function lex has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      lex: function(text) {
    this.text = text;
    this.index = 0;
    this.tokens = [];
                    Severity: Minor
                    Found in src/lib/debug-parse.js - About 1 hr to fix

                      Function shallowCopy has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function shallowCopy(src, dst) {
  if (isArray(src)) {
    dst = dst || [];

    for (var i = 0, ii = src.length; i < ii; i++) {
                      Severity: Minor
                      Found in src/lib/debug-parse.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function functionCall has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        functionCall: function(fnGetter, contextGetter) {
    var argsFn = [];
    if (this.peekToken().text !== ')') {
      do {
        argsFn.push(this.expression());
                      Severity: Minor
                      Found in src/lib/debug-parse.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language