Sign upLogin

angular/angular-hint

View on GitHub
Star

Showing 90 of 90 total issues

Function primary has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  primary: function() {
    var primary;
    if (this.expect('(')) {
      primary = this.filterChain();
      this.consume(')');
Severity: Minor
Found in src/lib/debug-parse.js - About 1 hr to fix

    Function object has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      object: function() {
    var keys = [], valueFns = [];
    if (this.peekToken().text !== '}') {
      do {
        if (this.peek('}')) {
    Severity: Minor
    Found in src/lib/debug-parse.js - About 1 hr to fix

      Function readNumber has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        readNumber: function() {
    var number = '';
    var start = this.index;
    while (this.index < this.text.length) {
      var ch = lowercase(this.text.charAt(this.index));
      Severity: Minor
      Found in src/lib/debug-parse.js - About 1 hr to fix

        Function scopeDescriptor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function scopeDescriptor (elt, scope) {
  var val,
      theseTypes = [],
      noDataDefault = 'scope.$id=' + scope.$id,
      type;
        Severity: Minor
        Found in src/modules/scopes.js - About 1 hr to fix

          Function filter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            filter: function(inputFn) {
    var fn = this.$filter(this.consume().text);
    var argsFn;
    var args;
          Severity: Minor
          Found in src/lib/debug-parse.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getterFn has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getterFn(path, options, fullExp) {
  var expensiveChecks = options.expensiveChecks;
  var getterFnCache = (expensiveChecks ? getterFnCacheExpensive : getterFnCacheDefault);
  var fn = getterFnCache[path];
  if (fn) return fn;
          Severity: Minor
          Found in src/lib/debug-parse.js - About 1 hr to fix

            Function filter has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              filter: function(inputFn) {
    var fn = this.$filter(this.consume().text);
    var argsFn;
    var args;
            Severity: Minor
            Found in src/lib/debug-parse.js - About 1 hr to fix

              Function compile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  $delegate[0].compile = function(element, attrs, transclude) {
      var linkFn = originalCompileFn.apply(this, arguments);

      return function ngEventHandler(scope, element, attrs) {
        var boundFuncs = getFunctionNames(attrs[ngEventAttrName]);
              Severity: Minor
              Found in src/modules/events.js - About 1 hr to fix

                Function forEach has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function forEach(obj, iterator, context) {
  var key, length;
  if (obj) {
    if (isFunction(obj)) {
      for (key in obj) {
                Severity: Minor
                Found in src/lib/debug-parse.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  describe('angularHint', function() {
  it('should warn if ng-hint is called with unknown options', function() {
    browser.get('exclude-wrong-module-name/');
    expect(consoleText())
        .toContain('Angular Hint: General; Warning; Module ngHintExcludeWrongModuleName could not be found;');
                  Severity: Major
                  Found in e2e/exclude-wrong-module-name/exclude-wrong-module-name.spec.js and 1 other location - About 1 hr to fix
                  e2e/include-wrong-module-name/include-wrong-module-name.spec.js on lines 5..11

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  describe('angularHint', function() {
  it('should warn if ng-hint is called with unknown options', function() {
    browser.get('include-wrong-module-name/');
    expect(consoleText())
        .toBe('Angular Hint: General; Warning; Module ngHintWrongModuleName could not be found;');
                  Severity: Major
                  Found in e2e/include-wrong-module-name/include-wrong-module-name.spec.js and 1 other location - About 1 hr to fix
                  e2e/exclude-wrong-module-name/exclude-wrong-module-name.spec.js on lines 5..11

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = function(doms) {
  var bothFound,
      ngViewFound,
      elem,
      isElemName,
                  Severity: Minor
                  Found in src/modules/angular-hint-modules/storeNgAppAndView.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function ensureSafeObject has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function ensureSafeObject(obj, fullExpression) {
  // nifty check if obj is Function that is fast and works across iframes and other contexts
  if (obj) {
    if (obj.constructor === obj) {
      throw $parseMinErr('isecfn',
                  Severity: Minor
                  Found in src/lib/debug-parse.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function cspSafeGetterFn has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function cspSafeGetterFn(key0, key1, key2, key3, key4, fullExp, expensiveChecks) {
                  Severity: Major
                  Found in src/lib/debug-parse.js - About 50 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                          for (key in obj) {
        if (obj.hasOwnProperty(key)) {
          iterator.call(context, obj[key], key, obj);
        }
      }
                    Severity: Major
                    Found in src/lib/debug-parse.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                if (isObject(source[key])) {
            stackSource.push(source[key]);
            stackDest.push(result);
          }
                      Severity: Major
                      Found in src/lib/debug-parse.js - About 45 mins to fix

                        Function arrayDeclaration has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                          arrayDeclaration: function() {
    var elementFns = [];
    if (this.peekToken().text !== ']') {
      do {
        if (this.peek(']')) {
                        Severity: Minor
                        Found in src/lib/debug-parse.js - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                              } else if (isRegExp(o1) && isRegExp(o2)) {
        return o1.toString() == o2.toString();
      } else {
        if (isScope(o1) || isScope(o2) || isWindow(o1) || isWindow(o2) || isArray(o2)) return false;
        keySet = {};
                        Severity: Major
                        Found in src/lib/debug-parse.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                  if (!isDate(o2)) return false;
                          Severity: Major
                          Found in src/lib/debug-parse.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                    if (isPrimitive || key in obj) {
          iterator.call(context, obj[key], key, obj);
        }
                            Severity: Major
                            Found in src/lib/debug-parse.js - About 45 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language