Sign upLogin

apimatic/core-lib-php

View on GitHub
Star
src/TestCase/BodyMatchers/BodyComparator.php

Summary

Maintainability
C
7 hrs
Test Coverage
A
100%

Method compare has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function compare($expected, $actual): bool
    {
        $bothNull = $this->checkForNull($expected, $actual);
        if (isset($bothNull)) {
            return !$this->checkValues || $bothNull;
Severity: Major
Found in src/TestCase/BodyMatchers/BodyComparator.php - About 2 hrs to fix

    Function compare has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function compare($expected, $actual): bool
    {
        $bothNull = $this->checkForNull($expected, $actual);
        if (isset($bothNull)) {
            return !$this->checkValues || $bothNull;
    Severity: Minor
    Found in src/TestCase/BodyMatchers/BodyComparator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function intersectArrays has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function intersectArrays(array $leftList, array $rightList): array
    {
        $commonList = [];
        foreach ($leftList as $leftVal) {
            foreach ($rightList as $rightVal) {
    Severity: Minor
    Found in src/TestCase/BodyMatchers/BodyComparator.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return !$this->checkValues || $this->isListProperSubsetOf($expected, $actual);
    Severity: Major
    Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return !$this->checkValues;
      Severity: Major
      Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return;
        Severity: Major
        Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return;
          Severity: Major
          Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return;
            Severity: Major
            Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $success;
              Severity: Major
              Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status