Sign upLogin

apotema/qbwc_requests

View on GitHub
Star
lib/qbwc_requests/ordered_fields.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method ordered_fields has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def ordered_fields
      return {} if self.class.attr_order.blank?
      new_hash = {}
      for attribute in self.class.attr_order
        value = send(attribute)
Severity: Minor
Found in lib/qbwc_requests/ordered_fields.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ref_to has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def ref_to attribute_prefix, name_length=nil
        attribute_name = "#{attribute_prefix}_ref".to_sym
        @attr_order ||= Set.new
        @attr_order << attribute_name
        attr_accessor attribute_name
Severity: Minor
Found in lib/qbwc_requests/ordered_fields.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def validate record
        return true if record.class.attr_order.blank?
        for field in record.class.attr_order
          value = record.send(field)
          if value.respond_to?(:valid?) and value.invalid?
Severity: Minor
Found in lib/qbwc_requests/ordered_fields.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status