Sign upLogin

appsignal/appsignal

View on GitHub
Star
lib/appsignal/cli/install.rb

Summary

Maintainability
C
1 day
Test Coverage

File install.rb has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "erb"
require "ostruct"
require "io/console"
require "appsignal/demo"
Severity: Minor
Found in lib/appsignal/cli/install.rb - About 2 hrs to fix

    Method run has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def run(push_api_key, options) # rubocop:disable Metrics/AbcSize
          self.coloring = options.delete(:color) { true }
          $stdout.sync = true

          puts
    Severity: Major
    Found in lib/appsignal/cli/install.rb - About 2 hrs to fix

      Method configure has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def configure(config, environments, name_overwritten)
          install_for_capistrano

          ENV["APPSIGNAL_APP_ENV"] = "development"
      Severity: Minor
      Found in lib/appsignal/cli/install.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                def run(push_api_key, options) # rubocop:disable Metrics/AbcSize
          self.coloring = options.delete(:color) { true }
          $stdout.sync = true

          puts
        Severity: Minor
        Found in lib/appsignal/cli/install.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method configure_rails_app_name has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def configure_rails_app_name(config)
          loaded =
            begin
              load Appsignal::Utils::RailsHelper.application_config_path
              true
        Severity: Minor
        Found in lib/appsignal/cli/install.rb - About 1 hr to fix

          Method installed_frameworks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                  def installed_frameworks
          [].tap do |out|
            if framework_available?("rails") &&
                File.exist?(Appsignal::Utils::RailsHelper.application_config_path)
              out << :rails
          Severity: Minor
          Found in lib/appsignal/cli/install.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method configure has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                  def configure(config, environments, name_overwritten)
          install_for_capistrano

          ENV["APPSIGNAL_APP_ENV"] = "development"
          Severity: Minor
          Found in lib/appsignal/cli/install.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def install_for_sinatra(config)
          puts "Installing for Sinatra"
          config[:name] = required_input("  Enter application name: ")
          puts
          configure(config, %w[development production staging], true)
          Severity: Minor
          Found in lib/appsignal/cli/install.rb and 1 other location - About 30 mins to fix
          lib/appsignal/cli/install.rb on lines 132..147

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def install_for_padrino(config)
          puts "Installing for Padrino"
          config[:name] = required_input("  Enter application name: ")
          puts
          configure(config, %w[development production staging], true)
          Severity: Minor
          Found in lib/appsignal/cli/install.rb and 1 other location - About 30 mins to fix
          lib/appsignal/cli/install.rb on lines 114..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status