Sign upLogin

appsignal/appsignal

View on GitHub
Star
lib/appsignal/helpers/instrumentation.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method monitor_transaction has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def monitor_transaction(name, env = {})
        # Always verify input, even when Appsignal is not active.
        # This makes it more likely invalid arguments get flagged in test/dev
        # environments.
        if name.start_with?("perform_job".freeze)
Severity: Minor
Found in lib/appsignal/helpers/instrumentation.rb - About 1 hr to fix

    Method send_error has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def send_error(
        error,
        tags = nil,
        namespace = Appsignal::Transaction::HTTP_REQUEST
      )
    Severity: Minor
    Found in lib/appsignal/helpers/instrumentation.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_error has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def set_error(exception, tags = nil, namespace = nil)
        unless exception.is_a?(Exception)
          logger.error "Appsignal.set_error: Cannot set error. The given " \
            "value is not an exception: #{exception.inspect}"
          return
    Severity: Minor
    Found in lib/appsignal/helpers/instrumentation.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method monitor_transaction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def monitor_transaction(name, env = {})
        # Always verify input, even when Appsignal is not active.
        # This makes it more likely invalid arguments get flagged in test/dev
        # environments.
        if name.start_with?("perform_job".freeze)
    Severity: Minor
    Found in lib/appsignal/helpers/instrumentation.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status