appsignal/appsignal

View on GitHub
lib/appsignal/hooks/sidekiq.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File sidekiq.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "yaml"

module Appsignal
  class Hooks
    class SidekiqHook < Appsignal::Hooks::Hook
Severity: Minor
Found in lib/appsignal/hooks/sidekiq.rb - About 2 hrs to fix

    Method call has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def call(_worker, item, _queue)
            job_status = nil
            transaction = Appsignal::Transaction.create(
              SecureRandom.uuid,
              Appsignal::Transaction::BACKGROUND_JOB,
    Severity: Minor
    Found in lib/appsignal/hooks/sidekiq.rb - About 1 hr to fix

      Method parse_arguments has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse_arguments(job)
              args = job.fetch("args", [])
              case job["class"]
              when /\ASidekiq::Extensions::Delayed/
                safe_load(args[0], args) do |_, _, arg|
      Severity: Minor
      Found in lib/appsignal/hooks/sidekiq.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_arguments has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def parse_arguments(job)
              args = job.fetch("args", [])
              case job["class"]
              when /\ASidekiq::Extensions::Delayed/
                safe_load(args[0], args) do |_, _, arg|
      Severity: Minor
      Found in lib/appsignal/hooks/sidekiq.rb - About 1 hr to fix

        Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def call(_worker, item, _queue)
                job_status = nil
                transaction = Appsignal::Transaction.create(
                  SecureRandom.uuid,
                  Appsignal::Transaction::BACKGROUND_JOB,
        Severity: Minor
        Found in lib/appsignal/hooks/sidekiq.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status