arikalfus/Jeeves

Function decode has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

base64.decode = function(s) {
    // convert to string
    s = "" + s;
    var getbyte64 = base64.getbyte64;
    var pads, i, b10;

Function encode has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

base64.encode = function(s) {
    if (arguments.length != 1) {
    throw "SyntaxError: Not enough arguments";
    }
    var padchar = base64.PADCHAR;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            } else if (results[i].match(/go to/) || results[i].match(/goto/) || results[i].match(/open/) || results[i].match(/go back/) || results[i].match(/take/)) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            } else if (results[i].match(/done/) || results[i].match(/go away/) || results[i].match(/that's all/) || results[i].match(/no/)) {

• Read up
  Read up

Function changeWeather has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $scope.changeWeather = function(setting) {

        var city = "";

        if(typeof setting == "boolean"){    // If the change is made by typing, the setting will be a boolean.

Function startTTS has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function startTTS() {
        navigator.tts.startup(success, fail);

        function success () {
            var $element = $('#body-controller-element');

Function changeView has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $scope.changeView = function(selected) {
        if (selected == 'back'){
            if ($scope.jeeves.isMenuOpen) {        // If the menu is open, the back button will just close the menu.
                $scope.closeMenu();
            } else {

Function newsSpeech has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $scope.newsSpeech = function(results){
        // Should only go to news page if it match anything from here.
        // ########Potential problem here: even though it is not "read something about news", it will still change the view to news.
        if ($scope.jeeves.view != 'news') {
            $scope.$apply(function(){

Function base64_decode has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function base64_decode(data) {
  //  discuss at: http://phpjs.org/functions/base64_decode/
  // original by: Tyler Akins (http://rumkin.com)
  // improved by: Thunder.m
  // improved by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)

Function globalCommands has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $scope.globalCommands = function(results) {
        for (var i = 0; i < results.length; i++){
            if (results[i] == "how is the weather" || results[i] == "how's the weather" || results[i] == "what's the weather" || results[i] == "what is the weather like today" || results[i] == "what's the weather like" || results[i] == "how's the weather today" || results[i] == "how is the weather today"){
                $scope.$apply(function() {
                    $scope.changeView("weather");

Function sayWebTitle has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $scope.sayWebTitle = function(section){
        $scope.adaptivePrompt();
        if ($scope.jeeves.newsPosition.section == "news"){
            navigator.tts.speak($scope.jeeves.newsArticles.news[$scope.jeeves.newsPosition.articleIndex].webTitle+ $scope.jeeves.webTitle.calledWebTitle, function() {
                $scope.reco($scope.dialogMan);

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        }else if ($scope.jeeves.view == 'about') {
            navigator.tts.speak("Nothing to do on this page! Let me open up the menu for you.", function() {
                $scope.$apply(function() {
                    $scope.changeView('menu');
                })

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

            if (results[i] == "how is the weather" || results[i] == "how's the weather" || results[i] == "what's the weather" || results[i] == "what is the weather like today" || results[i] == "what's the weather like" || results[i] == "how's the weather today" || results[i] == "how is the weather today"){
                $scope.$apply(function() {
                    $scope.changeView("weather");
                })
                navigator.tts.speak("The current temperature in " + $scope.jeeves.city + " is " + Math.round($scope.jeeves.weather.temp.current) + " degrees fahrenheit. " + $scope.jeeves.weather.description + ".", function() {

Function $get has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

      function($rootScope, $location, $routeParams, $q, $injector, $http, $templateCache, $sce) {

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        }else if ($scope.jeeves.view == 'contact') {
            navigator.tts.speak("Nothing to do on this page! Let me open up the menu for you.", function() {
                $scope.$apply(function() {
                    $scope.changeView('menu');
                })

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if ($scope.jeeves.view == 'email') {
                    $timeout(function() {
                        navigator.tts.speak("Would you like me to read your email?", function() {
                            $scope.reco($scope.confirmReadEmail);
                        })

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    if (OAuth.create("google_mail")) {
                        $timeout(function() {
                            navigator.tts.speak("What next?", function() {
                                $scope.reco($scope.dialogMan);
                            })

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                if (angular.isFunction(templateUrl)) {
                  templateUrl = templateUrl(next.params);
                }

Avoid deeply nested control flow statements.

Open

                if (angular.isDefined(templateUrl)) {
                  next.loadedTemplateUrl = templateUrl;
                  template = $http.get(templateUrl, {cache: $templateCache}).
                      then(function(response) { return response.data; });
                }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

              if (item.name == "From") {
                sender.setAttribute('id', 'email-sender');
                sender.innerHTML = '<b>From: ' + item.value + '</b><br>';
              }

• Read up
  Read up