Sign upLogin

arikalfus/Jeeves

View on GitHub
Star

Showing 108 of 108 total issues

Avoid deeply nested control flow statements.
Open

                if (angular.isDefined(templateUrl)) {
                  next.loadedTemplateUrl = templateUrl;
                  template = $http.get(templateUrl, {cache: $templateCache}).
                      then(function(response) { return response.data; });
                }
Severity: Major
Found in js/angular-route.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

            } else if ($scope.regXloop(results, 'settings')) {
            if ($scope.jeeves.view != 'settings') {
                navigator.tts.speak("On it.", function() {
                    $scope.$apply(function() {
                        $scope.changeView('settings');
    Severity: Major
    Found in js/mvc.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if ($scope.jeeves.view != 'menu') {
                navigator.tts.speak("On it.", function() {
                    $scope.$apply(function() {
                        $scope.changeView('menu');
                    });
      Severity: Major
      Found in js/mvc.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if($scope.regXloopForNews(results1[i], 'article')||$scope.regXloopForNews(results1[i], 'this')||$scope.regXloopForNews(results1[i], 'now')){
                $scope.readArticle();
                return true;
            }
            else{
        Severity: Minor
        Found in js/mvc.js and 1 other location - About 40 mins to fix
        js/mvc.js on lines 702..716

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else if($scope.regXloopForNews(results[i], 'previous five')||$scope.regXloopForNews(results[i], 'previous articles')||$scope.regXloopForNews(results[i], 'previous news')){
                $scope.$apply(function(){
                    $scope.differentFive($scope.jeeves.newsPosition.section,false);
                });
                return true;
        Severity: Minor
        Found in js/mvc.js and 1 other location - About 40 mins to fix
        js/mvc.js on lines 812..832

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Consider simplifying this complex logical expression.
        Open

                if ($scope.regXloopForNews(results, 'news')||$scope.regXloopForNews(results, 'world')||$scope.regXloopForNews(results, 'sports')||$scope.regXloopForNews(results, 'business')||$scope.regXloopForNews(results, 'tech')||$scope.regXloopForNews(results, 'science')){
                $scope.changeNewsHelper(results);
                return true;
            }
        Severity: Major
        Found in js/mvc.js - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                          if ($scope.regXloopForNews(results1[i], 'news')||$scope.regXloopForNews(results1[i], 'world')||$scope.regXloopForNews(results1[i], 'sports')||$scope.regXloopForNews(results1[i], 'business')||$scope.regXloopForNews(results1[i], 'tech')||$scope.regXloopForNews(results1[i], 'science')){
                    if($scope.changeNewsSection(results1[i])){
                        $scope.sayWebTitle($scope.jeeves.newsPosition.section);
                        return true;
                    }
          Severity: Major
          Found in js/mvc.js - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                  if (next && last && next.$$route === last.$$route
          && angular.equals(next.pathParams, last.pathParams)
          && !next.reloadOnSearch && !forceReload) {
        last.params = next.params;
        angular.copy(last.params, $routeParams);
            Severity: Major
            Found in js/angular-route.js - About 40 mins to fix

              Function link has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  link: function(scope, $element, attr, ctrl, $transclude) {
              Severity: Minor
              Found in js/angular-route.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else if($scope.regXloopForNews(results[i], 'more articles')){
                $scope.$apply(function(){
                    $scope.differentFive($scope.jeeves.newsPosition.section,true);
                });
                return true;
                Severity: Minor
                Found in js/mvc.js and 1 other location - About 35 mins to fix
                js/mvc.js on lines 702..716

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function decode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                base64.decode = function(s) {
    // convert to string
    s = "" + s;
    var getbyte64 = base64.getbyte64;
    var pads, i, b10;
                Severity: Minor
                Found in js/base64.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                                return true;
                Severity: Major
                Found in js/mvc.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return true;
                  Severity: Major
                  Found in js/mvc.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return $scope.changeNewsSection(results[i]);
                    Severity: Major
                    Found in js/mvc.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return false;
                      Severity: Major
                      Found in js/mvc.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return true;
                        Severity: Major
                        Found in js/mvc.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return true;
                          Severity: Major
                          Found in js/mvc.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return false;
                            Severity: Major
                            Found in js/mvc.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          return true;
                              Severity: Major
                              Found in js/mvc.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                            return true;
                                Severity: Major
                                Found in js/mvc.js - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language