arkaitzgarro/elastic-apm-laravel

View on GitHub
src/AgentBuilder.php

Summary

Maintainability
A
35 mins
Test Coverage
A
100%

Method newAgent has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Config $config,
        ContextCollection $sharedContext,
        Connector $connector,
        EventFactoryInterface $eventFactory,
        TransactionsStore $transactionsStore): ApmAgent
Severity: Minor
Found in src/AgentBuilder.php - About 35 mins to fix

    The parameter $app_config is not named in camelCase.
    Open

        public function withAppConfig(Repository $app_config): self
        {
            $this->app_config = $app_config;
    
            return $this;
    Severity: Minor
    Found in src/AgentBuilder.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
        public function doSomething($user_name) {
        }
    }

    Source

    The property $app_config is not named in camelCase.
    Open

    class AgentBuilder extends NipwaayoniAgentBuilder
    {
        /** @var Repository */
        private $app_config;
    
    
    Severity: Minor
    Found in src/AgentBuilder.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
        protected $property_name;
    }

    Source

    The variable $app_config is not named in camelCase.
    Open

        public function withAppConfig(Repository $app_config): self
        {
            $this->app_config = $app_config;
    
            return $this;
    Severity: Minor
    Found in src/AgentBuilder.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status