Sign upLogin

arkaitzgarro/elastic-apm-laravel

View on GitHub
Star
src/Collectors/HttpRequestCollector.php

Summary

Maintainability
A
45 mins
Test Coverage
B
82%

Function getController has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getController(): ?string
    {
        $router = $this->app['router'];

        $route = $router->current();
Severity: Minor
Found in src/Collectors/HttpRequestCollector.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method getController uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $controller = $controller[0] . '::' . $controller[1];
            }
Severity: Minor
Found in src/Collectors/HttpRequestCollector.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Define a constant instead of duplicating this literal "request_handled" 3 times.
Open

            $this->startMeasure('request_handled', 'laravel', 'request', $this->getController());
Severity: Critical
Found in src/Collectors/HttpRequestCollector.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

There are no issues that match your filters.

Category
Status