Sign upLogin

artirix/artirix_data_models

View on GitHub
Star
lib/artirix_data_models/daos/basic_model_dao.rb

Summary

Maintainability
D
1 day
Test Coverage

Class BasicModelDAO has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

class ArtirixDataModels::BasicModelDAO
  include ArtirixDataModels::DAOConcerns::WithResponseAdaptors
  include ArtirixDataModels::WithADMRegistry

  attr_reader :model_name, :model_class, :paths_factory, :fake_mode_factory, :gateway_factory
Severity: Minor
Found in lib/artirix_data_models/daos/basic_model_dao.rb - About 3 hrs to fix

    File basic_model_dao.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ArtirixDataModels::BasicModelDAO
  include ArtirixDataModels::DAOConcerns::WithResponseAdaptors
  include ArtirixDataModels::WithADMRegistry

  attr_reader :model_name, :model_class, :paths_factory, :fake_mode_factory, :gateway_factory
    Severity: Minor
    Found in lib/artirix_data_models/daos/basic_model_dao.rb - About 2 hrs to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def perform_get(path,
                  authorization_bearer: nil,
                  authorization_token_hash: nil,
                  body: nil,
                  cache_adaptor: nil,
      Severity: Major
      Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def perform_delete(path,
                     authorization_bearer: nil,
                     authorization_token_hash: nil,
                     body: nil,
                     cache_adaptor: nil,
      Severity: Major
      Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def perform_put(path,
                  authorization_bearer: nil,
                  authorization_token_hash: nil,
                  body: nil,
                  cache_adaptor: nil,
      Severity: Major
      Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def perform_patch(path,
                    authorization_bearer: nil,
                    authorization_token_hash: nil,
                    body: nil,
                    cache_adaptor: nil,
      Severity: Major
      Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        def perform_post(path,
                   authorization_bearer: nil,
                   authorization_token_hash: nil,
                   body: nil,
                   cache_adaptor: nil,
      Severity: Major
      Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305
      lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status