artirix/artirix_data_models

View on GitHub
lib/artirix_data_models/raw_aggregation_data_normaliser.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method locate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def self.locate(comparator, object, result = [])
      if object.is_a?(::Enumerable)
        if object.any? { |value| match_comparator?(value, comparator, object) }
          result.push object
        else # DO NOT LOOK DEEPER ONCE FOUND IF THE VALUE FOUND IS A HASH (this will prevent us from properly recognising nested aggregations)!
Severity: Minor
Found in lib/artirix_data_models/raw_aggregation_data_normaliser.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method normalise_element has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def normalise_element(name, value)
      return unless Hash === value

      if value.key?(:buckets)
        add_normalised_buckets_element_to_list(name, value)
Severity: Minor
Found in lib/artirix_data_models/raw_aggregation_data_normaliser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status