arttor/helmify

View on GitHub
pkg/processor/job/job.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method job.Process has 84 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p job) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
    if obj.GroupVersionKind() != jobGVC {
        return false, nil, nil
    }
    meta, err := processor.ProcessObjMeta(appMeta, obj)
Severity: Major
Found in pkg/processor/job/job.go - About 2 hrs to fix

    Method job.Process has 16 return statements (exceeds 4 allowed).
    Open

    func (p job) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
        if obj.GroupVersionKind() != jobGVC {
            return false, nil, nil
        }
        meta, err := processor.ProcessObjMeta(appMeta, obj)
    Severity: Major
    Found in pkg/processor/job/job.go - About 1 hr to fix

      Method job.Process has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
      Open

      func (p job) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
          if obj.GroupVersionKind() != jobGVC {
              return false, nil, nil
          }
          meta, err := processor.ProcessObjMeta(appMeta, obj)
      Severity: Minor
      Found in pkg/processor/job/job.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function templateSpecVal has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func templateSpecVal(val any, values *helmify.Values, specMap map[string]interface{}, objName string, fieldName ...string) error {
      Severity: Minor
      Found in pkg/processor/job/job.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status