Sign upLogin

arttor/helmify

View on GitHub
Star
pkg/processor/pod/pod.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function processPodContainer has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func processPodContainer(name string, appMeta helmify.AppMetadata, c corev1.Container, values *helmify.Values) (corev1.Container, error) {
    index := strings.LastIndex(c.Image, ":")
    if strings.Contains(c.Image, "@") && strings.Count(c.Image, ":") >= 2 {
        last := strings.LastIndex(c.Image, ":")
        index = strings.LastIndex(c.Image[:last], ":")
Severity: Minor
Found in pkg/processor/pod/pod.go - About 1 hr to fix

    Function ProcessSpec has 8 return statements (exceeds 4 allowed).
    Open

    func ProcessSpec(objName string, appMeta helmify.AppMetadata, spec corev1.PodSpec) (map[string]interface{}, helmify.Values, error) {
    values, err := processPodSpec(objName, appMeta, &spec)
    if err != nil {
        return nil, nil, err
    }
    Severity: Major
    Found in pkg/processor/pod/pod.go - About 50 mins to fix

      Function processPodContainer has 8 return statements (exceeds 4 allowed).
      Open

      func processPodContainer(name string, appMeta helmify.AppMetadata, c corev1.Container, values *helmify.Values) (corev1.Container, error) {
    index := strings.LastIndex(c.Image, ":")
    if strings.Contains(c.Image, "@") && strings.Count(c.Image, ":") >= 2 {
        last := strings.LastIndex(c.Image, ":")
        index = strings.LastIndex(c.Image[:last], ":")
      Severity: Major
      Found in pkg/processor/pod/pod.go - About 50 mins to fix

        Function processContainers has 6 return statements (exceeds 4 allowed).
        Open

        func processContainers(objName string, values helmify.Values, containerType string, containers []interface{}) ([]interface{}, helmify.Values, error) {
    for i := range containers {
        containerName := strcase.ToLowerCamel((containers[i].(map[string]interface{})["name"]).(string))
        res, exists, err := unstructured.NestedMap(values, objName, containerName, "resources")
        if err != nil {
        Severity: Major
        Found in pkg/processor/pod/pod.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              for _, v := range pod.Volumes {
        if v.ConfigMap != nil {
            v.ConfigMap.Name = appMeta.TemplatedName(v.ConfigMap.Name)
        }
        if v.Secret != nil {
          Severity: Minor
          Found in pkg/processor/pod/pod.go and 1 other location - About 30 mins to fix
          pkg/processor/pod/pod.go on lines 195..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              for _, e := range c.EnvFrom {
        if e.SecretRef != nil {
            e.SecretRef.Name = appMeta.TemplatedName(e.SecretRef.Name)
        }
        if e.ConfigMapRef != nil {
          Severity: Minor
          Found in pkg/processor/pod/pod.go and 1 other location - About 30 mins to fix
          pkg/processor/pod/pod.go on lines 151..158

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status