Classes/Controller/OembedController.php
Method startRequestLoop has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private function startRequestLoop(Configuration $configuration): void
{
$response = null;
$request = null;
The class OembedController has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13. Open
Open
class OembedController extends ActionController
{
private ConfigurationFactory $configurationFactory;
private ContainerInterface $container;- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}