Sign upLogin

astehlik/typo3-extension-mediaoembed

View on GitHub
Star
Classes/Domain/Model/Content.php

Summary

Maintainability
A
45 mins
Test Coverage
A
100%

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        int $uid,
        string $url,
        int $maxHeight = 0,
        int $maxWidth = 0,
        bool $playRelated = true,
Severity: Minor
Found in Classes/Domain/Model/Content.php - About 45 mins to fix

    The method __construct has a boolean flag argument $playRelated, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $playRelated = true,
    Severity: Minor
    Found in Classes/Domain/Model/Content.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Arguments with default values must be at the end of the argument list
    Open

            string $aspectRatio = '',
    Severity: Minor
    Found in Classes/Domain/Model/Content.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status