# asteris-llc/converge

graph/graph.go

### Summary

D
2 days

#### Function `dependencyWalk` has a Cognitive Complexity of 53 (exceeds 20 allowed). Consider refactoring. Open

``````func dependencyWalk(rctx context.Context, g *Graph, cb WalkFunc) error {
// the basic idea of this implementation is that we want to defer schedule
// children of any given node until after that node's non-child dependencies
// are satisfied. We're going to have a couple major components of this.
// First, a scheduler/latch to make sure we don't schedule work more than``````
Found in graph/graph.go - About 5 hrs to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### `Graph` has 33 methods (exceeds 20 allowed). Consider refactoring. Open

``````type Graph struct {
inner  *dag.AcyclicGraph
values cmap.ConcurrentMap

innerLock *sync.RWMutex``````
Found in graph/graph.go - About 4 hrs to fix

#### Function `dependencyWalk` has 127 lines of code (exceeds 50 allowed). Consider refactoring. Open

``````func dependencyWalk(rctx context.Context, g *Graph, cb WalkFunc) error {
// the basic idea of this implementation is that we want to defer schedule
// children of any given node until after that node's non-child dependencies
// are satisfied. We're going to have a couple major components of this.
// First, a scheduler/latch to make sure we don't schedule work more than``````
Found in graph/graph.go - About 4 hrs to fix

#### Function `dependencyWalk` has 14 return statements (exceeds 4 allowed). Open

``````func dependencyWalk(rctx context.Context, g *Graph, cb WalkFunc) error {
// the basic idea of this implementation is that we want to defer schedule
// children of any given node until after that node's non-child dependencies
// are satisfied. We're going to have a couple major components of this.
// First, a scheduler/latch to make sure we don't schedule work more than``````
Found in graph/graph.go - About 1 hr to fix

#### Method `Graph.IsNibling` has 5 return statements (exceeds 4 allowed). Open

``````func (g *Graph) IsNibling(fst, snd string) bool {
sndID, sndHasParent := g.GetParentID(snd)
if !sndHasParent {
return false
}``````
Found in graph/graph.go - About 35 mins to fix

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````func (g *Graph) SafeDisconnect(from, to string) error {
g.innerLock.Lock()
defer g.innerLock.Unlock()

g.inner.RemoveEdge(dag.BasicEdge(from, to))``````
Found in graph/graph.go and 1 other location - About 1 hr to fix
graph/graph.go on lines 173..184

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````func (g *Graph) SafeConnect(from, to string) error {
g.innerLock.Lock()
defer g.innerLock.Unlock()

g.inner.Connect(dag.BasicEdge(from, to))``````
Found in graph/graph.go and 1 other location - About 1 hr to fix
graph/graph.go on lines 195..206

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````func (g *Graph) UpEdges(id string) (out []dag.Edge) {
g.innerLock.RLock()
defer g.innerLock.RUnlock()

for _, edge := range g.inner.Edges() {``````
Found in graph/graph.go and 1 other location - About 55 mins to fix
graph/graph.go on lines 223..234

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````func (g *Graph) DownEdges(id string) (out []dag.Edge) {
g.innerLock.RLock()
defer g.innerLock.RUnlock()

for _, edge := range g.inner.Edges() {``````
Found in graph/graph.go and 1 other location - About 55 mins to fix
graph/graph.go on lines 209..220

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.