asteris-llc/converge

View on GitHub

Showing 247 of 615 total issues

Method ExportExtractor.Visit has 7 return statements (exceeds 4 allowed).
Open

func (e *ExportExtractor) Visit(node ast.Node) (w ast.Visitor) {
    switch n := node.(type) {
    case *ast.File, *ast.TypeSpec, *ast.FieldList:
        return e
    case *ast.StructType:
Severity: Major
Found in docs/extract.go - About 45 mins to fix

    Function simpleApplyFailure has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func simpleApplyFailure(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
    Severity: Minor
    Found in resource/lvm/vg/vg_test.go - About 45 mins to fix

      Function simpleApplySuccess has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func simpleApplySuccess(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
      Severity: Minor
      Found in resource/lvm/vg/vg_test.go - About 45 mins to fix

        Method Fetch.applyWithContext has 7 return statements (exceeds 4 allowed).
        Open

        func (f *Fetch) applyWithContext(context.Context) (resource.TaskStatus, error) {
            var (
                hsh      hash.Hash
                err      error
                status   = resource.NewStatus()
        Severity: Major
        Found in resource/file/fetch/fetch.go - About 45 mins to fix

          Function getFailedReason has 7 return statements (exceeds 4 allowed).
          Open

          func getFailedReason(u *Unit) (string, error) {
              err := errors.New("unable to determine cause of failure: no properties available")
              var reason string
              switch u.Type {
              case UnitTypeService:
          Severity: Major
          Found in resource/systemd/unit/resource.go - About 45 mins to fix

            Method Fetch.DiffFile has 7 return statements (exceeds 4 allowed).
            Open

            func (f *Fetch) DiffFile(status *resource.Status, hsh hash.Hash) (*resource.Status, error) {
                // the destination should be a file if fetching without an unarchive
                // if unarchiving, the destination should be a directory
                stat, err := os.Stat(f.Destination)
                if err == nil {
            Severity: Major
            Found in resource/file/fetch/fetch.go - About 45 mins to fix

              Function ResolveDependencies has 7 return statements (exceeds 4 allowed).
              Open

              func ResolveDependencies(ctx context.Context, g *graph.Graph) (*graph.Graph, error) {
                  logger := logging.GetLogger(ctx).WithField("function", "ResolveDependencies")
                  logger.Debug("resolving dependencies")
              
                  groupLock := new(sync.Mutex)
              Severity: Major
              Found in load/dependencyresolver.go - About 45 mins to fix

                Method Network.Apply has 6 return statements (exceeds 4 allowed).
                Open

                func (n *Network) Apply(context.Context) (resource.TaskStatus, error) {
                    status := resource.NewStatus()
                
                    var (
                        nw  *dc.Network
                Severity: Major
                Found in resource/docker/network/network.go - About 40 mins to fix

                  Method CommandResults.Eq has 6 return statements (exceeds 4 allowed).
                  Open

                  func (c *CommandResults) Eq(cmd *CommandResults) bool {
                      if c == nil || cmd == nil {
                          return false
                      }
                      if c.ExitStatus != cmd.ExitStatus {
                  Severity: Major
                  Found in resource/shell/command_results.go - About 40 mins to fix

                    Function mergeMaybeUnresolvables has 6 return statements (exceeds 4 allowed).
                    Open

                    func mergeMaybeUnresolvables(err1, err2 error) error {
                        if err1 == nil {
                            return err2
                        }
                        if err2 == nil {
                    Severity: Major
                    Found in render/render.go - About 40 mins to fix

                      Method Preparer.convertNumber has 6 return statements (exceeds 4 allowed).
                      Open

                      func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                          if val == nil {
                              return reflect.Zero(typ), nil
                          }
                      
                      
                      Severity: Major
                      Found in resource/preparer.go - About 40 mins to fix

                        Function Parse has 6 return statements (exceeds 4 allowed).
                        Open

                        func Parse(content []byte) (resources []*Node, err error) {
                            obj, err := hcl.ParseBytes(content)
                            if err != nil {
                                return resources, err
                            }
                        Severity: Major
                        Found in parse/parse.go - About 40 mins to fix

                          Method commandIOContext.exec has 6 return statements (exceeds 4 allowed).
                          Open

                          func (c *commandIOContext) exec(script string) (results *CommandResults, err error) {
                              results = &CommandResults{
                                  Stdin: script,
                              }
                          
                          
                          Severity: Major
                          Found in resource/shell/command_executor.go - About 40 mins to fix

                            Function isExportedField has 6 return statements (exceeds 4 allowed).
                            Open

                            func isExportedField(input interface{}, index int) bool {
                                if nil == input {
                                    return false
                                }
                            
                            
                            Severity: Major
                            Found in resource/field_extractor.go - About 40 mins to fix

                              Function TraverseUntilModule has 6 return statements (exceeds 4 allowed).
                              Open

                              func TraverseUntilModule(g *graph.Graph, id string) bool {
                                  if graph.IsRoot(id) {
                                      return true
                                  }
                                  elemMeta, ok := g.Get(id)
                              Severity: Major
                              Found in render/preprocessor/preprocessor.go - About 40 mins to fix

                                Method pipelineGen.PlanNode has 6 return statements (exceeds 4 allowed).
                                Open

                                func (g *pipelineGen) PlanNode(ctx context.Context, taski interface{}) (interface{}, error) {
                                    twrapper, ok := taski.(taskWrapper)
                                    if !ok {
                                        asResult, ok := taski.(*Result)
                                        if ok {
                                Severity: Major
                                Found in plan/pipeline.go - About 40 mins to fix

                                  Method Server.newREST has 6 return statements (exceeds 4 allowed).
                                  Open

                                  func (s *Server) newREST(ctx context.Context, addr *url.URL) (*http.Server, error) {
                                      opts, err := s.Security.Client()
                                      if err != nil {
                                          return nil, errors.Wrap(err, "could not generate REST gateway security options")
                                      }
                                  Severity: Major
                                  Found in rpc/server.go - About 40 mins to fix

                                    Method User.Check has 6 return statements (exceeds 4 allowed).
                                    Open

                                    func (u *User) Check(context.Context, resource.Renderer) (resource.TaskStatus, error) {
                                        // lookup the user by name
                                        // ErrUnsupported is returned if the system is not supported
                                        // Lookup returns user.UnknownUserError if the user is not found
                                        userByName, nameErr := u.system.Lookup(u.Username)
                                    Severity: Major
                                    Found in resource/user/user.go - About 40 mins to fix

                                      Function WithNotify has 6 return statements (exceeds 4 allowed).
                                      Open

                                      func WithNotify(ctx context.Context, in *graph.Graph, notify *graph.Notifier) (*graph.Graph, error) {
                                          var hasErrors error
                                      
                                          out, err := in.Transform(ctx,
                                              notify.Transform(func(meta *node.Node, out *graph.Graph) error {
                                      Severity: Major
                                      Found in plan/plan.go - About 40 mins to fix

                                        Method Unarchive.isMemAvailable has 6 return statements (exceeds 4 allowed).
                                        Open

                                        func (u *Unarchive) isMemAvailable() (bool, error) {
                                            var (
                                                destStat syscall.Statfs_t
                                                tmpStat  syscall.Statfs_t
                                            )
                                        Severity: Major
                                        Found in resource/unarchive/unarchive.go - About 40 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language