asteris-llc/converge

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-valid", func(t *testing.T) {
            t.Parallel()
            p := &Preparer{
                SignalNumber: 9,
                executor:     &ExecutorMock{},

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-lowercase", func(t *testing.T) {
            t.Parallel()
            p := &Preparer{
                SignalName: "kill",
                executor:   &ExecutorMock{},

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-sig-prefix", func(t *testing.T) {
            t.Parallel()
            p := &Preparer{
                SignalName: "sigkill",
                executor:   &ExecutorMock{},

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        t.Run("error-groupname not found", func(t *testing.T) {
            u := user.NewUser(new(user.System))
            u.Username = currUsername
            u.GroupName = fakeGroupName
            status := resource.NewStatus()

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        t.Run("error-groupname not found", func(t *testing.T) {
            u := user.NewUser(new(user.System))
            u.Username = fakeUsername
            u.GroupName = fakeGroupName
            status := resource.NewStatus()

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        t.Run("error-uid found", func(t *testing.T) {
            u := user.NewUser(new(user.System))
            u.Username = fakeUsername
            u.UID = currUID
            status := resource.NewStatus()

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        t.Run("error-gid not found", func(t *testing.T) {
            u := user.NewUser(new(user.System))
            u.Username = fakeUsername
            u.GID = fakeGID
            status := resource.NewStatus()

• Read up
  Read up

Function newSliceTypePropertiesFromMap has 68 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func newSliceTypePropertiesFromMap(m map[string]interface{}) *SliceTypeProperties {
    s := &SliceTypeProperties{}

    if val, ok := m["BlockIOAccounting"]; ok {
        s.BlockIOAccounting = val.(bool)

Similar blocks of code found in 2 locations. Consider refactoring.

Open

// Copyright © 2016 Asteris, LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

// Copyright © 2016 Asteris, LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at

• Read up
  Read up

Function ExportedFields has 67 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func ExportedFields(input interface{}) (exported []*ExportedField, err error) {
    nonEmbeddedFields := make(map[string]struct{})
    embeddedFields := make(map[string][]*ExportedField)
    if nil == input {
        return exported, ErrNilStruct

Identical blocks of code found in 2 locations. Consider refactoring.

Open

type fakeAPIClient struct {
    FindImageFunc       func(repoTag string) (*dc.Image, error)
    PullImageFunc       func(name, tag string) error
    FindContainerFunc   func(name string) (*dc.Container, error)
    CreateContainerFunc func(opts dc.CreateContainerOptions) (*dc.Container, error)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

type fakeAPIClient struct {
    FindImageFunc       func(repoTag string) (*dc.Image, error)
    PullImageFunc       func(name, tag string) error
    FindContainerFunc   func(name string) (*dc.Container, error)
    CreateContainerFunc func(opts dc.CreateContainerOptions) (*dc.Container, error)

• Read up
  Read up

Method Preparer.convertNumber has 65 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }

Method User.DiffAdd has 65 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (u *User) DiffAdd(status *resource.Status) (*AddUserOptions, error) {
    options := new(AddUserOptions)

    // if a group exists with the same name as the user being added, a groupname
    // must also be indicated so the user may be added to that group

Function TestRenderConditionals has 65 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func TestRenderConditionals(t *testing.T) {
    defer logging.HideLogs(t)()

    src := `
param "a" {

Method Signal.String has 65 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (s Signal) String() string {
    switch s {
    case SIGHUP:
        return "SIGHUP"
    case SIGINT:

Method TypeExtractor.Visit has 65 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (te *TypeExtractor) Visit(node ast.Node) (w ast.Visitor) {
    if node == nil {
        return nil
    }

Function TestVGCheck has 65 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func TestVGCheck(t *testing.T) {
    t.Run("check prerequisites failure", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        m.On("Check").Return(fmt.Errorf("failed"))
        _ = simpleCheckFailure(t, lvm, "vg0", []string{"/dev/sda1"}, false, false)

Method Group.Apply has 16 return statements (exceeds 4 allowed).

Open

func (g *Group) Apply(context.Context) (resource.TaskStatus, error) {
    var (
        groupByGid *user.Group
        gidErr     error
        newNameErr error