astratto/kitchen-inspector

View on GitHub
lib/kitchen-inspector/inspector/report/status_reporter.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method single_status has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def single_status(dep)
          return mark_structure(:err_req) if dep.status == :err_req

          return mark_structure(:err_repo) if dep.repomanager[:status] == :err_repo

Severity: Minor
Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return mark_structure(:warn_mismatch_repo) if dep.repomanager[:status] == :warn_mismatch_repo
Severity: Major
Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return mark_structure(:warn_notunique_repo) if dep.repomanager[:status] == :warn_notunique_repo
    Severity: Major
    Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return mark_structure(:warn_chef) if dep.chef[:status] == :warn_chef
      Severity: Major
      Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status