Sign upLogin

atk4/ui

View on GitHub
Star

Showing 1,792 of 1,794 total issues

The method addActionMenuItem has a boolean flag argument $isDisabled, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addActionMenuItem($view, $action = null, string $confirmMsg = '', $isDisabled = false)
Severity: Minor
Found in src/Grid.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method _setOrAppend has a boolean flag argument $throwIfNotFound, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function _setOrAppend($tag, ?string $value = null, bool $encodeHtml = true, bool $append = false, bool $throwIfNotFound = true): void
Severity: Minor
Found in src/HtmlTemplate.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Remove error control operator '@' on line 408.
Open

    public function tryLoadFromFile(string $filename)
    {
        // realpath() is slow on Windows, so cache it and dedup only directories
        $filenameBase = basename($filename);
        $filename = dirname($filename);
Severity: Minor
Found in src/HtmlTemplate.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '69', column '23').
Open

            throw new \TypeError('$fx must be of type Closure');
Severity: Minor
Found in src/JsCallback.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method jsChecked has a boolean flag argument $when, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function jsChecked($when = false, $action = null): JsExpressionable
Severity: Minor
Found in src/Form/Control/Checkbox.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method jsSuccess has a boolean flag argument $useTemplate, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function jsSuccess($success = 'Success', $subHeader = null, bool $useTemplate = true): JsExpressionable
Severity: Minor
Found in src/Form.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method loadFromString has a boolean flag argument $allowParseCache, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function loadFromString(string $str, bool $allowParseCache = false): self
Severity: Minor
Found in src/HtmlTemplate.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addQuickSearch has a boolean flag argument $hasAutoQuery, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addQuickSearch($fields = [], $hasAutoQuery = false): void
Severity: Minor
Found in src/Grid.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addActionMenuItem has a boolean flag argument $isDisabled, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addActionMenuItem($item, $action = null, string $confirmMsg = '', $isDisabled = false)
Severity: Minor
Found in src/Table/Column/ActionMenu.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addActionButton has a boolean flag argument $isDisabled, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addActionButton($button, $action = null, string $confirmMsg = '', $isDisabled = false)
Severity: Minor
Found in src/Grid.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method jsDisplayWarning has a boolean flag argument $state, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function jsDisplayWarning(bool $state = true): JsExpressionable
Severity: Minor
Found in src/Panel/Right.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addModal has a boolean flag argument $isDisabled, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addModal($button, $defaults, \Closure $callback, $owner = null, $args = [], $isDisabled = false)
Severity: Minor
Found in src/Table/Column/ActionButtons.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '140', column '29').
Open

                $date = new \DateTime('-' . $this->get('number_days') . ' days');
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDatetime.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method _setOrAppend has a boolean flag argument $append, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function _setOrAppend($tag, ?string $value = null, bool $encodeHtml = true, bool $append = false, bool $throwIfNotFound = true): void
Severity: Minor
Found in src/HtmlTemplate.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method _setOrAppend has a boolean flag argument $encodeHtml, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function _setOrAppend($tag, ?string $value = null, bool $encodeHtml = true, bool $append = false, bool $throwIfNotFound = true): void
Severity: Minor
Found in src/HtmlTemplate.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addModalAction has a boolean flag argument $isDisabled, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addModalAction($button, $title, \Closure $callback, $args = [], $isDisabled = false)
Severity: Minor
Found in src/Grid.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '161', column '38').
Open

                        $value = new \DateTime($value->format('Y-m-d H:i:s.u'), $value->getTimezone());
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '145', column '29').
Open

                $date = new \DateTime('+' . $this->get('number_days') . ' days');
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDatetime.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '115', column '29').
Open

                $date = new \DateTime('-' . $this->get('number_days') . ' days');
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '47', column '23').
Open

            throw new \TypeError('$fx must be of type Closure');
Severity: Minor
Found in src/JsSse.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language