Showing 19 of 19 total issues
Use tr
instead of gsub
. Open
song.gsub('_', ' ').gsub('-', ' - ')
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Do not prefix reader method names with get_
. Open
def get_url_status
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Prefer single-quoted strings when you don't need string interpolation or special symbols. Open
message: "should exist once per server" }
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
self.get_url_play
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
self.playlist_items.create(song: @song)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Missing top-level class documentation comment. Open
class Stream < ActiveRecord::Base
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, self.mount).to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Do not prefix reader method names with get_
. Open
def get_url_play
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Use def with parentheses when there are parameters. Open
def get_current_song doc
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
self.get_url_status
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Do not place comments on the same line as the def
keyword. Open
def url_status # returns full url
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Use def with parentheses when there are parameters. Open
def fix_song_title song
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Use def with parentheses when there are parameters. Open
def open_url url
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
page = open_url(self.get_url_status)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Extra empty line detected at class body end. Open
end
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Line is too long. [82/80] Open
doc.xpath('//td[contains(text(),"Current Song")]//following-sibling::td').text
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, self.mount).to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks