atzorvas/ccradio

Missing top-level class documentation comment.
class Stream < ActiveRecord::Base
  has_many :playlist_items
  validates :title, :server, :mount, presence: true
  validates :title, uniqueness: true
  validates :mount, uniqueness: { scope: :server,
Prefer single-quoted strings when you don't need string interpolation or special symbols.
                                  message: "should exist once per server" }
  scope :enabled, -> { where(enabled: true) }
 
Do not place comments on the same line as the `def` keyword.
  def url_status # returns full url
Redundant `self` detected.
    self.get_url_status
  end
 
  def url_play
Redundant `self` detected.
    self.get_url_play
  end
 
  def self.sync_playlists
    enabled.map(&:sync_latest_song)
  end
 
  def sync_latest_song
    require 'open-uri'
Redundant `self` detected.
    page = open_url(self.get_url_status)
    song = get_current_song(page)
    @song = fix_song_title(song)
    save_song
  end
 
  protected
 
  def save_song
Redundant `self` detected.
    self.playlist_items.create(song: @song)
  end
 
Use def with parentheses when there are parameters.
  def fix_song_title song
Use `tr` instead of `gsub`.
    song.gsub('_', ' ').gsub('-', ' - ')
  end
 
Use def with parentheses when there are parameters.
  def get_current_song doc
Line is too long. [82/80]
    doc.xpath('//td[contains(text(),"Current Song")]//following-sibling::td').text
  end
 
Use def with parentheses when there are parameters.
  def open_url url
    Nokogiri::HTML.parse open(url).read
  end
 
Do not prefix reader method names with `get_`.
  def get_url_status
Redundant `self` detected.
    URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
  end
 
Do not prefix reader method names with `get_`.
  def get_url_play
Redundant `self` detected.
    URI.join(self.server, self.mount).to_s
  end
Extra empty line detected at class body end.
 
end