Showing 218 of 218 total issues
Use def with parentheses when there are parameters. Open
def fix_song_title song
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Missing top-level module documentation comment. Open
module ApplicationHelper
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Keep a blank line before and after private
. Open
private
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
self.get_url_status
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Align the parameters of a method call if they span more than one line. Open
:recoverable, :rememberable, :trackable, :validatable,
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Space missing after comma. Open
user.password = Devise.friendly_token[0,20]
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Missing top-level class documentation comment. Open
class User < ActiveRecord::Base
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Line is too long. [82/80] Open
doc.xpath('//td[contains(text(),"Current Song")]//following-sibling::td').text
- Create a ticketCreate a ticket
- Exclude checks
Use tr
instead of gsub
. Open
song.gsub('_', ' ').gsub('-', ' - ')
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
page = open_url(self.get_url_status)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Prefer single-quoted strings when you don't need string interpolation or special symbols. Open
message: "should exist once per server" }
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Do not use when x;
. Use when x then
instead. Open
when :error; 'alert-danger'
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Do not prefix reader method names with get_
. Open
def get_url_play
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, self.mount).to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Align the parameters of a method call if they span more than one line. Open
only: [:show, :edit, :update, :destroy, :playlist, :current_song]
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Redundant self
detected. Open
URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Do not introduce global variables. Open
$redis.publish "songs", { song: self }.to_json
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Prefer single-quoted strings when you don't need string interpolation or special symbols. Open
$redis.publish "songs", { song: self }.to_json
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Align the parameters of a method call if they span more than one line. Open
except: [:show, :index, :playlist, :current_song, :subscription]
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks