atzorvas/ccradio

View on GitHub

Showing 218 of 218 total issues

Use def with parentheses when there are parameters.
Open

def fix_song_title song
Severity: Minor
Found in app/models/stream.rb by rubocop

Redundant self detected.
Open

URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
Severity: Minor
Found in app/models/stream.rb by rubocop

Missing top-level module documentation comment.
Open

module ApplicationHelper
Severity: Minor
Found in app/helpers/application_helper.rb by rubocop

Keep a blank line before and after private.
Open

private

Redundant self detected.
Open

self.get_url_status
Severity: Minor
Found in app/models/stream.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

:recoverable, :rememberable, :trackable, :validatable,
Severity: Minor
Found in app/models/user.rb by rubocop

Space missing after comma.
Open

user.password = Devise.friendly_token[0,20]
Severity: Minor
Found in app/models/user.rb by rubocop

Missing top-level class documentation comment.
Open

class User < ActiveRecord::Base
Severity: Minor
Found in app/models/user.rb by rubocop

Line is too long. [82/80]
Open

doc.xpath('//td[contains(text(),"Current Song")]//following-sibling::td').text
Severity: Minor
Found in app/models/stream.rb by rubocop

Use tr instead of gsub.
Open

song.gsub('_', ' ').gsub('-', ' - ')
Severity: Minor
Found in app/models/stream.rb by rubocop

Redundant self detected.
Open

page = open_url(self.get_url_status)
Severity: Minor
Found in app/models/stream.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

message: "should exist once per server" }
Severity: Minor
Found in app/models/stream.rb by rubocop

Do not use when x;. Use when x then instead.
Open

when :error; 'alert-danger'
Severity: Minor
Found in app/helpers/application_helper.rb by rubocop

Do not prefix reader method names with get_.
Open

def get_url_play
Severity: Minor
Found in app/models/stream.rb by rubocop

Redundant self detected.
Open

URI.join(self.server, self.mount).to_s
Severity: Minor
Found in app/models/stream.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

only: [:show, :edit, :update, :destroy, :playlist, :current_song]

Redundant self detected.
Open

URI.join(self.server, "status.xsl?mount=#{self.mount}").to_s
Severity: Minor
Found in app/models/stream.rb by rubocop

Do not introduce global variables.
Open

$redis.publish "songs", { song: self }.to_json
Severity: Minor
Found in app/models/playlist_item.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

$redis.publish "songs", { song: self }.to_json
Severity: Minor
Found in app/models/playlist_item.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

except: [:show, :index, :playlist, :current_song, :subscription]
Severity
Category
Status
Source
Language