Sign upLogin

aureooms/sak

View on GitHub
Star

Showing 350 of 350 total issues

File args.py has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import lib.json
import itertools
import lib.error
import inspect
Severity: Minor
Found in lib/args.py - About 4 hrs to fix

    Function ParseArguments has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    def ParseArguments(args):
    """Parses the command line arguments.

    This may set the output format and verbosity level as side-effects.
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CheckForFunctionLengths has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckForFunctionLengths(filename, clean_lines, linenum,
                            function_state, error):
    """Reports for long function bodies.

    For an overview why this is done, see:
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CheckStyle has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckStyle(filename, clean_lines, linenum, file_extension, nesting_state,
               error):
    """Checks rules from the 'C++ style rules' section of cppguide.html.

    Most of these rules are hard to test (naming, comment style), but we
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CheckOperatorSpacing has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckOperatorSpacing(filename, clean_lines, linenum, error):
    """Checks for horizontal spacing around operators.

    Args:
            filename: The name of the current file.
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CheckForHeaderGuard has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckForHeaderGuard(filename, lines, error):
    """Checks that the file contains a header guard.

    Logs an error if no #ifndef header guard is present.  For other
    headers, checks that the full pathname is used.
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function IsRValueAllowed has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def IsRValueAllowed(clean_lines, linenum):
    """Check if RValue reference is allowed on a particular line.

    Args:
            clean_lines: A CleansedLines instance containing the file.
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def coverallscoverage(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):

    title = "Coverage Status"
    img = sio.coveralls(username, repo, style=style, fmt=fmt)
    href = "https://coveralls.io/r/%s/%s" % (username, repo)
    Severity: Major
    Found in lib/ghbadges.py and 5 other locations - About 3 hrs to fix
    lib/ghbadges.py on lines 55..61
    lib/ghbadges.py on lines 82..88
    lib/ghbadges.py on lines 91..97
    lib/ghbadges.py on lines 100..106
    lib/ghbadges.py on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def codeclimategpa(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):

    title = "Code Climate"
    img = sio.codeclimategithub(username, repo, style=style, fmt=fmt)
    href = "https://codeclimate.com/github/%s/%s" % (username, repo)
    Severity: Major
    Found in lib/ghbadges.py and 5 other locations - About 3 hrs to fix
    lib/ghbadges.py on lines 55..61
    lib/ghbadges.py on lines 73..79
    lib/ghbadges.py on lines 82..88
    lib/ghbadges.py on lines 91..97
    lib/ghbadges.py on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function CheckTrailingSemicolon has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
    """Looks for redundant trailing semicolon.

    Args:
            filename: The name of the current file.
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def daviddevdependencies(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):

    title = "devDependencies Status"
    img = sio.daviddev(username, repo, style=style, fmt=fmt)
    href = "https://david-dm.org/%s/%s#info=devDependencies" % (username, repo)
    Severity: Major
    Found in lib/ghbadges.py and 5 other locations - About 3 hrs to fix
    lib/ghbadges.py on lines 55..61
    lib/ghbadges.py on lines 73..79
    lib/ghbadges.py on lines 82..88
    lib/ghbadges.py on lines 100..106
    lib/ghbadges.py on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def githubissues(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):

    title = "GitHub issues"
    img = sio.githubissues(username, repo, style=style, fmt=fmt)
    href = "https://github.com/%s/%s/issues" % (username, repo)
    Severity: Major
    Found in lib/ghbadges.py and 5 other locations - About 3 hrs to fix
    lib/ghbadges.py on lines 55..61
    lib/ghbadges.py on lines 73..79
    lib/ghbadges.py on lines 82..88
    lib/ghbadges.py on lines 91..97
    lib/ghbadges.py on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function CheckIncludeLine has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
    """Check rules that are applicable to #include lines.

    Strings on #include lines are NOT removed from elided line, to make
    certain tasks easier. However, to prevent false positives, checks
    Severity: Minor
    Found in lib/cpplint.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def daviddependencies(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):

    title = "Dependencies Status"
    img = sio.david(username, repo, style=style, fmt=fmt)
    href = "https://david-dm.org/%s/%s#info=dependencies" % (username, repo)
    Severity: Major
    Found in lib/ghbadges.py and 5 other locations - About 3 hrs to fix
    lib/ghbadges.py on lines 55..61
    lib/ghbadges.py on lines 73..79
    lib/ghbadges.py on lines 91..97
    lib/ghbadges.py on lines 100..106
    lib/ghbadges.py on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    def traviscibuild(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):

    title = "Build Status"
    img = sio.travis(username, repo, style=style, fmt=fmt)
    href = "https://travis-ci.com/%s/%s" % (username, repo)
    Severity: Major
    Found in lib/ghbadges.py and 5 other locations - About 3 hrs to fix
    lib/ghbadges.py on lines 73..79
    lib/ghbadges.py on lines 82..88
    lib/ghbadges.py on lines 91..97
    lib/ghbadges.py on lines 100..106
    lib/ghbadges.py on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function splitparts has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    def splitparts(string, argv, i=0, j=None, eos=None, buf="", escapefirst=False):
    """
            Splits a command line argument string into tokens. Tokens are separated
            by whitespace. Whitespace can be included inside tokens by wrapping tokens with
            single or double quotes. Whitespace can also be included by escaping them
    Severity: Minor
    Found in lib/args.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def ghpageesdoc(username=None,repo=None,packagename=None,style=FLAT,fmt=SVG):

    """

            >>> from lib.ghbadges import ghpageesdoc
    Severity: Major
    Found in lib/ghbadges.py and 1 other location - About 2 hrs to fix
    lib/ghbadges.py on lines 118..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function CheckSpacingForFunctionCall has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    def CheckSpacingForFunctionCall(filename, clean_lines, linenum, error):
    """Checks for the correctness of various spacing around function calls.

    Args:
            filename: The name of the current file.
    Severity: Minor
    Found in lib/cpplint.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def inchci(username=None, repo=None, packagename=None, style=FLAT, fmt=SVG):
    """

            >>> from lib.ghbadges import inchci
            >>> print( inchci( "make-github-pseudonymous-again" , "js-algebra" ) )
    Severity: Major
    Found in lib/ghbadges.py and 1 other location - About 2 hrs to fix
    lib/ghbadges.py on lines 134..148

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _CollapseStrings has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def _CollapseStrings(elided):
        """Collapses strings and chars on a line to simple "" or '' blocks.

        We nix strings first so we're not fooled by text like '"http://"'
    Severity: Minor
    Found in lib/cpplint.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language