Sign upLogin

autowp/autowp

View on GitHub
Star
module/Application/src/Controller/Api/IndexController.php

Summary

Maintainability
D
1 day
Test Coverage
F
0%

Method specItemsAction has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function specItemsAction(): JsonModel
    {
        $language = $this->language();

        $cacheKey = 'API_INDEX_SPEC_CARS_3_' . $language;
Severity: Major
Found in module/Application/src/Controller/Api/IndexController.php - About 3 hrs to fix

    Function itemOfDayAction has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function itemOfDayAction(): JsonModel
    {
        $language = $this->language();
        /** @var Request $request */
        $request   = $this->getRequest();
    Severity: Minor
    Found in module/Application/src/Controller/Api/IndexController.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method itemOfDayAction has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function itemOfDayAction(): JsonModel
    {
        $language = $this->language();
        /** @var Request $request */
        $request   = $this->getRequest();
    Severity: Major
    Found in module/Application/src/Controller/Api/IndexController.php - About 2 hrs to fix

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              StorageInterface $cache,
        Item $item,
        SpecificationsService $specsService,
        User $userModel,
        CarOfDay $itemOfDay,
      Severity: Major
      Found in module/Application/src/Controller/Api/IndexController.php - About 1 hr to fix

        Function specItemsAction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function specItemsAction(): JsonModel
    {
        $language = $this->language();

        $cacheKey = 'API_INDEX_SPEC_CARS_3_' . $language;
        Severity: Minor
        Found in module/Application/src/Controller/Api/IndexController.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                    switch ($path['type']) {
                                case 'brand':
                                    $route = ['/', $path['brand_catname']];
                                    break;
                                case 'category':
        Severity: Major
        Found in module/Application/src/Controller/Api/IndexController.php - About 45 mins to fix

          The method itemOfDayAction() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
          Open

              public function itemOfDayAction(): JsonModel
    {
        $language = $this->language();
        /** @var Request $request */
        $request   = $this->getRequest();
          Severity: Minor
          Found in module/Application/src/Controller/Api/IndexController.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          syntax error, unexpected 'StorageInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
          Open

              private StorageInterface $cache;
          Severity: Critical
          Found in module/Application/src/Controller/Api/IndexController.php by phan

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public function __construct(
        StorageInterface $cache,
        Item $item,
        SpecificationsService $specsService,
        User $userModel,
          Severity: Major
          Found in module/Application/src/Controller/Api/IndexController.php and 5 other locations - About 2 hrs to fix
          module/Application/src/Controller/Api/ItemLanguageController.php on lines 60..78
          module/Application/src/Controller/Api/PictureItemController.php on lines 59..77
          module/Application/src/Controller/Api/PictureModerVoteController.php on lines 55..73
          module/Application/src/Model/Log.php on lines 36..54
          module/Application/src/Service/PictureService.php on lines 52..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 132.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status