File ItemParentController.php
has 434 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace Application\Controller\Api;
use Application\Controller\Plugin\Car;
Method indexAction
has 111 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function indexAction()
{
$user = $this->user()->get();
$isModer = $this->user()->enforce('global', 'moderate');
Function indexAction
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
public function indexAction()
{
$user = $this->user()->get();
$isModer = $this->user()->enforce('global', 'moderate');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class ItemParentController has an overall complexity of 64 which is very high. The configured complexity threshold is 50. Open
class ItemParentController extends AbstractRestfulController
{
private AbstractRestHydrator $hydrator;
private ItemParent $itemParent;
- Exclude checks
Method postAction
has 79 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
Method deleteAction
has 63 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function deleteAction()
{
if (! $this->user()->enforce('car', 'move')) {
return $this->forbiddenAction();
}
Method putAction
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function putAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
Function postAction
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function postAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function putAction
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function putAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 12 arguments (exceeds 4 allowed). Consider refactoring. Open
AbstractRestHydrator $hydrator,
InputFilter $listInputFilter,
InputFilter $itemInputFilter,
InputFilter $postInputFilter,
InputFilter $putInputFilter,
Function deleteAction
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function deleteAction()
{
if (! $this->user()->enforce('car', 'move')) {
return $this->forbiddenAction();
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $response->setStatusCode(Response::STATUS_CODE_201);
Avoid too many return
statements within this method. Open
return $this->notFoundAction();
Avoid too many return
statements within this method. Open
return $response->setStatusCode(Response::STATUS_CODE_200);
Avoid too many return
statements within this method. Open
return $response->setStatusCode(Response::STATUS_CODE_204);
The method postAction() has an NPath complexity of 1536. The configured NPath complexity threshold is 200. Open
public function postAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method indexAction() has an NPath complexity of 276480. The configured NPath complexity threshold is 200. Open
public function indexAction()
{
$user = $this->user()->get();
$isModer = $this->user()->enforce('global', 'moderate');
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method deleteAction() has an NPath complexity of 384. The configured NPath complexity threshold is 200. Open
public function deleteAction()
{
if (! $this->user()->enforce('car', 'move')) {
return $this->forbiddenAction();
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method putAction() has an NPath complexity of 768. The configured NPath complexity threshold is 200. Open
public function putAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method __construct has 12 parameters. Consider reducing the number of parameters to less than 10. Open
public function __construct(
AbstractRestHydrator $hydrator,
InputFilter $listInputFilter,
InputFilter $itemInputFilter,
InputFilter $postInputFilter,
- Exclude checks
The method indexAction() has 140 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function indexAction()
{
$user = $this->user()->get();
$isModer = $this->user()->enforce('global', 'moderate');
- Exclude checks
The method postAction() has 104 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function postAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Exclude checks
The method postAction() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function postAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method deleteAction() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public function deleteAction()
{
if (! $this->user()->enforce('car', 'move')) {
return $this->forbiddenAction();
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method indexAction() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10. Open
public function indexAction()
{
$user = $this->user()->get();
$isModer = $this->user()->enforce('global', 'moderate');
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method putAction() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function putAction()
{
$canMove = $this->user()->enforce('car', 'move');
if (! $canMove) {
return $this->forbiddenAction();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class ItemParentController has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13. Open
class ItemParentController extends AbstractRestfulController
{
private AbstractRestHydrator $hydrator;
private ItemParent $itemParent;
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method indexAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$select->where(['NOT item.is_concept_inherit']);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method postAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$data = $request->getPost()->toArray();
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method indexAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$select->where(['NOT item.is_concept']);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
syntax error, unexpected 'AbstractRestHydrator' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open
private AbstractRestHydrator $hydrator;
- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
foreach ($subscribers as $subscriber) {
if ((int) $subscriber['id'] !== (int) $user['id']) {
$uri = $this->hostManager->getUriByLanguage($subscriber['language']);
$message = sprintf(
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 182.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
foreach ($subscribers as $subscriber) {
if ((int) $subscriber['id'] !== (int) $user['id']) {
$uri = $this->hostManager->getUriByLanguage($subscriber['language']);
$message = sprintf(
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 182.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $specificationsService. Keep variable name length under 20. Open
SpecificationsService $specificationsService,
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $specificationsService. Keep variable name length under 20. Open
private SpecificationsService $specificationsService;
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}