autowp/autowp

View on GitHub
module/Application/src/Controller/Api/PictureController.php

Summary

Maintainability
F
2 wks
Test Coverage
F
33%

Function updateAction has a Cognitive Complexity of 160 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateAction()
    {
        $user = $this->user()->get();
        if (! $user) {
            return $this->forbiddenAction();
Severity: Minor
Found in module/Application/src/Controller/Api/PictureController.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File PictureController.php has 1108 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Application\Controller\Api;

use Application\Comments;
Severity: Major
Found in module/Application/src/Controller/Api/PictureController.php - About 2 days to fix

    Method updateAction has 278 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateAction()
        {
            $user = $this->user()->get();
            if (! $user) {
                return $this->forbiddenAction();
    Severity: Major
    Found in module/Application/src/Controller/Api/PictureController.php - About 1 day to fix

      Function indexAction has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
      Open

          public function indexAction()
          {
              $isModer = $this->user()->enforce('global', 'moderate');
              $user    = $this->user()->get();
      
      
      Severity: Minor
      Found in module/Application/src/Controller/Api/PictureController.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method indexAction has 202 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function indexAction()
          {
              $isModer = $this->user()->enforce('global', 'moderate');
              $user    = $this->user()->get();
      
      
      Severity: Major
      Found in module/Application/src/Controller/Api/PictureController.php - About 1 day to fix

        Method acceptReplaceAction has 87 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function acceptReplaceAction()
            {
                if (! $this->user()->enforce('global', 'moderate')) {
                    return $this->forbiddenAction();
                }
        Severity: Major
        Found in module/Application/src/Controller/Api/PictureController.php - About 3 hrs to fix

          The class PictureController has 16 public methods. Consider refactoring PictureController to keep number of public methods under 10.
          Open

          class PictureController extends AbstractRestfulController
          {
              private CarOfDay $carOfDay;
          
              private AbstractRestHydrator $hydrator;

          TooManyPublicMethods

          Since: 0.1

          A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

          By default it ignores methods starting with 'get' or 'set'.

          Example

          Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

          The class PictureController has an overall complexity of 209 which is very high. The configured complexity threshold is 50.
          Open

          class PictureController extends AbstractRestfulController
          {
              private CarOfDay $carOfDay;
          
              private AbstractRestHydrator $hydrator;

          Function canonicalRouteAction has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function canonicalRouteAction()
              {
                  /** @psalm-suppress InvalidCast */
                  $picture = $this->picture->getRow(['identity' => (string) $this->params('id')]);
          
          
          Severity: Minor
          Found in module/Application/src/Controller/Api/PictureController.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 22 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  AbstractRestHydrator $hydrator,
                  PictureItem $pictureItem,
                  DuplicateFinder $duplicateFinder,
                  UserPicture $userPicture,
                  HostManager $hostManager,
          Severity: Major
          Found in module/Application/src/Controller/Api/PictureController.php - About 2 hrs to fix

            Method canonicalRouteAction has 62 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function canonicalRouteAction()
                {
                    /** @psalm-suppress InvalidCast */
                    $picture = $this->picture->getRow(['identity' => (string) $this->params('id')]);
            
            
            Severity: Major
            Found in module/Application/src/Controller/Api/PictureController.php - About 2 hrs to fix

              Function acceptReplaceAction has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function acceptReplaceAction()
                  {
                      if (! $this->user()->enforce('global', 'moderate')) {
                          return $this->forbiddenAction();
                      }
              Severity: Minor
              Found in module/Application/src/Controller/Api/PictureController.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function carOfDayPictureAction has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function carOfDayPictureAction(): JsonModel
                  {
                      $itemOfDay = $this->carOfDay->getCurrent();
              
                      $pictureRow = null;
              Severity: Minor
              Found in module/Application/src/Controller/Api/PictureController.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method postAction has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function postAction()
                  {
                      $user = $this->user()->get();
                      if (! $user) {
                          return $this->forbiddenAction();
              Severity: Minor
              Found in module/Application/src/Controller/Api/PictureController.php - About 1 hr to fix

                Method carOfDayPictureAction has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function carOfDayPictureAction(): JsonModel
                    {
                        $itemOfDay = $this->carOfDay->getCurrent();
                
                        $pictureRow = null;
                Severity: Minor
                Found in module/Application/src/Controller/Api/PictureController.php - About 1 hr to fix

                  The class PictureController has 22 fields. Consider redesigning PictureController to keep the number of fields under 15.
                  Open

                  class PictureController extends AbstractRestfulController
                  {
                      private CarOfDay $carOfDay;
                  
                      private AbstractRestHydrator $hydrator;

                  TooManyFields

                  Since: 0.1

                  Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

                  Example

                  class Person {
                     protected $one;
                     private $two;
                     private $three;
                     [... many more fields ...]
                  }

                  Source https://phpmd.org/rules/codesize.html#toomanyfields

                  Function canReplace has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function canReplace($picture, $replacedPicture): bool
                      {
                          $can1 = false;
                          switch ($picture['status']) {
                              case Picture::STATUS_ACCEPTED:
                  Severity: Minor
                  Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                          if ($isFirstTimeAccepted) {
                                              if ($owner && ((int) $owner['id'] !== (int) $user['id'])) {
                                                  $uri = $this->hostManager->getUriByLanguage($owner['language']);
                  
                                                  $uri->setPath('/picture/' . urlencode($picture['identity']));
                  Severity: Major
                  Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            if ($prevUser) {
                                                $uri = $this->hostManager->getUriByLanguage($prevUser['language']);
                    
                                                $uri->setPath('/picture/' . urlencode($picture['identity']))->toString();
                    
                    
                    Severity: Major
                    Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if ($userRow) {
                                                      $uri = $this->hostManager->getUriByLanguage($userRow['language']);
                                                      $uri->setPath('/moder/pictures/' . $picture['id']);
                      
                                                      $message = sprintf(
                      Severity: Major
                      Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if ($owner) {
                                                    $this->userPicture->refreshPicturesCount($owner['id']);
                                                }
                        Severity: Major
                        Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if (! $canRestore) {
                                                      return $this->forbiddenAction();
                                                  }
                          Severity: Major
                          Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if ($picture['owner_id']) {
                                                        $this->userPicture->refreshPicturesCount($picture['owner_id']);
                                                    }
                            Severity: Major
                            Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if ($previousStatusUserId !== (int) $user['id']) {
                                                          $prevUser = $this->userModel->getRow($previousStatusUserId);
                                                          if ($prevUser) {
                                                              $uri = $this->hostManager->getUriByLanguage($prevUser['language']);
                              
                              
                              Severity: Major
                              Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                            if ($user) {
                                                                $reasons[] = $this->userModerUrl($user, $uri) . ' : ' . $request['reason'];
                                                            }
                                Severity: Major
                                Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                  switch ($perspectiveId) {
                                                                      case 22:
                                                                          $action = 'logotypes';
                                                                          break;
                                                                      case 25:
                                  Severity: Major
                                  Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            if (! $canUnaccept) {
                                                                return $this->forbiddenAction();
                                                            }
                                    Severity: Major
                                    Found in module/Application/src/Controller/Api/PictureController.php - About 45 mins to fix

                                      Function pictureCanDelete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private function pictureCanDelete($picture): bool
                                          {
                                              if (! $this->picture->canDelete($picture)) {
                                                  return false;
                                              }
                                      Severity: Minor
                                      Found in module/Application/src/Controller/Api/PictureController.php - About 35 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Avoid too many return statements within this method.
                                      Open

                                                              return $this->notFoundAction();
                                      Severity: Major
                                      Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                    return $this->forbiddenAction();
                                        Severity: Major
                                        Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                  return $response->setStatusCode(Response::STATUS_CODE_200);
                                          Severity: Major
                                          Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                                        return $this->forbiddenAction();
                                            Severity: Major
                                            Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                                      return $this->forbiddenAction();
                                              Severity: Major
                                              Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                        return $response->setStatusCode(Response::STATUS_CODE_200);
                                                Severity: Major
                                                Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                          return $this->forbiddenAction();
                                                  Severity: Major
                                                  Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                    return $this->forbiddenAction();
                                                    Severity: Major
                                                    Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                                  return $this->forbiddenAction();
                                                      Severity: Major
                                                      Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                                return $this->forbiddenAction();
                                                        Severity: Major
                                                        Found in module/Application/src/Controller/Api/PictureController.php - About 30 mins to fix

                                                          The method updateAction() has 350 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                          Open

                                                              public function updateAction()
                                                              {
                                                                  $user = $this->user()->get();
                                                                  if (! $user) {
                                                                      return $this->forbiddenAction();

                                                          The method acceptReplaceAction() has an NPath complexity of 7680. The configured NPath complexity threshold is 200.
                                                          Open

                                                              public function acceptReplaceAction()
                                                              {
                                                                  if (! $this->user()->enforce('global', 'moderate')) {
                                                                      return $this->forbiddenAction();
                                                                  }

                                                          NPathComplexity

                                                          Since: 0.1

                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                          Example

                                                          class Foo {
                                                              function bar() {
                                                                  // lots of complicated code
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                          The method indexAction() has an NPath complexity of 339771801600. The configured NPath complexity threshold is 200.
                                                          Open

                                                              public function indexAction()
                                                              {
                                                                  $isModer = $this->user()->enforce('global', 'moderate');
                                                                  $user    = $this->user()->get();
                                                          
                                                          

                                                          NPathComplexity

                                                          Since: 0.1

                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                          Example

                                                          class Foo {
                                                              function bar() {
                                                                  // lots of complicated code
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                          The method updateAction() has an NPath complexity of 24426479968. The configured NPath complexity threshold is 200.
                                                          Open

                                                              public function updateAction()
                                                              {
                                                                  $user = $this->user()->get();
                                                                  if (! $user) {
                                                                      return $this->forbiddenAction();

                                                          NPathComplexity

                                                          Since: 0.1

                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                          Example

                                                          class Foo {
                                                              function bar() {
                                                                  // lots of complicated code
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                          The method __construct has 22 parameters. Consider reducing the number of parameters to less than 10.
                                                          Open

                                                              public function __construct(
                                                                  AbstractRestHydrator $hydrator,
                                                                  PictureItem $pictureItem,
                                                                  DuplicateFinder $duplicateFinder,
                                                                  UserPicture $userPicture,

                                                          The method acceptReplaceAction() has 112 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                          Open

                                                              public function acceptReplaceAction()
                                                              {
                                                                  if (! $this->user()->enforce('global', 'moderate')) {
                                                                      return $this->forbiddenAction();
                                                                  }

                                                          The method indexAction() has 246 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                          Open

                                                              public function indexAction()
                                                              {
                                                                  $isModer = $this->user()->enforce('global', 'moderate');
                                                                  $user    = $this->user()->get();
                                                          
                                                          

                                                          The class PictureController has 1401 lines of code. Current threshold is 1000. Avoid really long classes.
                                                          Open

                                                          class PictureController extends AbstractRestfulController
                                                          {
                                                              private CarOfDay $carOfDay;
                                                          
                                                              private AbstractRestHydrator $hydrator;

                                                          The method indexAction() has a Cyclomatic Complexity of 57. The configured cyclomatic complexity threshold is 10.
                                                          Open

                                                              public function indexAction()
                                                              {
                                                                  $isModer = $this->user()->enforce('global', 'moderate');
                                                                  $user    = $this->user()->get();
                                                          
                                                          

                                                          CyclomaticComplexity

                                                          Since: 0.1

                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                          Example

                                                          // Cyclomatic Complexity = 11
                                                          class Foo {
                                                          1   public function example() {
                                                          2       if ($a == $b) {
                                                          3           if ($a1 == $b1) {
                                                                          fiddle();
                                                          4           } elseif ($a2 == $b2) {
                                                                          fiddle();
                                                                      } else {
                                                                          fiddle();
                                                                      }
                                                          5       } elseif ($c == $d) {
                                                          6           while ($c == $d) {
                                                                          fiddle();
                                                                      }
                                                          7        } elseif ($e == $f) {
                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                          fiddle();
                                                                      }
                                                                  } else {
                                                                      switch ($z) {
                                                          9               case 1:
                                                                              fiddle();
                                                                              break;
                                                          10              case 2:
                                                                              fiddle();
                                                                              break;
                                                          11              case 3:
                                                                              fiddle();
                                                                              break;
                                                                          default:
                                                                              fiddle();
                                                                              break;
                                                                      }
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                          The method canonicalRouteAction() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                                                          Open

                                                              public function canonicalRouteAction()
                                                              {
                                                                  /** @psalm-suppress InvalidCast */
                                                                  $picture = $this->picture->getRow(['identity' => (string) $this->params('id')]);
                                                          
                                                          

                                                          CyclomaticComplexity

                                                          Since: 0.1

                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                          Example

                                                          // Cyclomatic Complexity = 11
                                                          class Foo {
                                                          1   public function example() {
                                                          2       if ($a == $b) {
                                                          3           if ($a1 == $b1) {
                                                                          fiddle();
                                                          4           } elseif ($a2 == $b2) {
                                                                          fiddle();
                                                                      } else {
                                                                          fiddle();
                                                                      }
                                                          5       } elseif ($c == $d) {
                                                          6           while ($c == $d) {
                                                                          fiddle();
                                                                      }
                                                          7        } elseif ($e == $f) {
                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                          fiddle();
                                                                      }
                                                                  } else {
                                                                      switch ($z) {
                                                          9               case 1:
                                                                              fiddle();
                                                                              break;
                                                          10              case 2:
                                                                              fiddle();
                                                                              break;
                                                          11              case 3:
                                                                              fiddle();
                                                                              break;
                                                                          default:
                                                                              fiddle();
                                                                              break;
                                                                      }
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                          The method acceptReplaceAction() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
                                                          Open

                                                              public function acceptReplaceAction()
                                                              {
                                                                  if (! $this->user()->enforce('global', 'moderate')) {
                                                                      return $this->forbiddenAction();
                                                                  }

                                                          CyclomaticComplexity

                                                          Since: 0.1

                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                          Example

                                                          // Cyclomatic Complexity = 11
                                                          class Foo {
                                                          1   public function example() {
                                                          2       if ($a == $b) {
                                                          3           if ($a1 == $b1) {
                                                                          fiddle();
                                                          4           } elseif ($a2 == $b2) {
                                                                          fiddle();
                                                                      } else {
                                                                          fiddle();
                                                                      }
                                                          5       } elseif ($c == $d) {
                                                          6           while ($c == $d) {
                                                                          fiddle();
                                                                      }
                                                          7        } elseif ($e == $f) {
                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                          fiddle();
                                                                      }
                                                                  } else {
                                                                      switch ($z) {
                                                          9               case 1:
                                                                              fiddle();
                                                                              break;
                                                          10              case 2:
                                                                              fiddle();
                                                                              break;
                                                          11              case 3:
                                                                              fiddle();
                                                                              break;
                                                                          default:
                                                                              fiddle();
                                                                              break;
                                                                      }
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                          The method updateAction() has a Cyclomatic Complexity of 58. The configured cyclomatic complexity threshold is 10.
                                                          Open

                                                              public function updateAction()
                                                              {
                                                                  $user = $this->user()->get();
                                                                  if (! $user) {
                                                                      return $this->forbiddenAction();

                                                          CyclomaticComplexity

                                                          Since: 0.1

                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                          Example

                                                          // Cyclomatic Complexity = 11
                                                          class Foo {
                                                          1   public function example() {
                                                          2       if ($a == $b) {
                                                          3           if ($a1 == $b1) {
                                                                          fiddle();
                                                          4           } elseif ($a2 == $b2) {
                                                                          fiddle();
                                                                      } else {
                                                                          fiddle();
                                                                      }
                                                          5       } elseif ($c == $d) {
                                                          6           while ($c == $d) {
                                                                          fiddle();
                                                                      }
                                                          7        } elseif ($e == $f) {
                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                          fiddle();
                                                                      }
                                                                  } else {
                                                                      switch ($z) {
                                                          9               case 1:
                                                                              fiddle();
                                                                              break;
                                                          10              case 2:
                                                                              fiddle();
                                                                              break;
                                                          11              case 3:
                                                                              fiddle();
                                                                              break;
                                                                          default:
                                                                              fiddle();
                                                                              break;
                                                                      }
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                          The method canReplace() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                                          Open

                                                              private function canReplace($picture, $replacedPicture): bool
                                                              {
                                                                  $can1 = false;
                                                                  switch ($picture['status']) {
                                                                      case Picture::STATUS_ACCEPTED:

                                                          CyclomaticComplexity

                                                          Since: 0.1

                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                          Example

                                                          // Cyclomatic Complexity = 11
                                                          class Foo {
                                                          1   public function example() {
                                                          2       if ($a == $b) {
                                                          3           if ($a1 == $b1) {
                                                                          fiddle();
                                                          4           } elseif ($a2 == $b2) {
                                                                          fiddle();
                                                                      } else {
                                                                          fiddle();
                                                                      }
                                                          5       } elseif ($c == $d) {
                                                          6           while ($c == $d) {
                                                                          fiddle();
                                                                      }
                                                          7        } elseif ($e == $f) {
                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                          fiddle();
                                                                      }
                                                                  } else {
                                                                      switch ($z) {
                                                          9               case 1:
                                                                              fiddle();
                                                                              break;
                                                          10              case 2:
                                                                              fiddle();
                                                                              break;
                                                          11              case 3:
                                                                              fiddle();
                                                                              break;
                                                                          default:
                                                                              fiddle();
                                                                              break;
                                                                      }
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                          The class PictureController has a coupling between objects value of 29. Consider to reduce the number of dependencies under 13.
                                                          Open

                                                          class PictureController extends AbstractRestfulController
                                                          {
                                                              private CarOfDay $carOfDay;
                                                          
                                                              private AbstractRestHydrator $hydrator;

                                                          CouplingBetweenObjects

                                                          Since: 1.1.0

                                                          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                                                          Example

                                                          class Foo {
                                                              /**
                                                               * @var \foo\bar\X
                                                               */
                                                              private $x = null;
                                                          
                                                              /**
                                                               * @var \foo\bar\Y
                                                               */
                                                              private $y = null;
                                                          
                                                              /**
                                                               * @var \foo\bar\Z
                                                               */
                                                              private $z = null;
                                                          
                                                              public function setFoo(\Foo $foo) {}
                                                              public function setBar(\Bar $bar) {}
                                                              public function setBaz(\Baz $baz) {}
                                                          
                                                              /**
                                                               * @return \SplObjectStorage
                                                               * @throws \OutOfRangeException
                                                               * @throws \InvalidArgumentException
                                                               * @throws \ErrorException
                                                               */
                                                              public function process(\Iterator $it) {}
                                                          
                                                              // ...
                                                          }

                                                          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                                                          The method canonicalRouteAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                          Open

                                                                                      } else {
                                                                                          $perspectiveId = $this->pictureItem->getPerspective($picture['id'], $carId);
                                                          
                                                                                          switch ($perspectiveId) {
                                                                                              case 22:

                                                          ElseExpression

                                                          Since: 1.4.0

                                                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                          Example

                                                          class Foo
                                                          {
                                                              public function bar($flag)
                                                              {
                                                                  if ($flag) {
                                                                      // one branch
                                                                  } else {
                                                                      // another branch
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                          The method indexAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                          Open

                                                                  } else {
                                                                      $filter['order'] = $orders[1];
                                                                  }

                                                          ElseExpression

                                                          Since: 1.4.0

                                                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                          Example

                                                          class Foo
                                                          {
                                                              public function bar($flag)
                                                              {
                                                                  if ($flag) {
                                                                      // one branch
                                                                  } else {
                                                                      // another branch
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                          The method updateAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                          Open

                                                                          } else {
                                                                              $set['point'] = null;
                                                                          }

                                                          ElseExpression

                                                          Since: 1.4.0

                                                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                          Example

                                                          class Foo
                                                          {
                                                              public function bar($flag)
                                                              {
                                                                  if ($flag) {
                                                                      // one branch
                                                                  } else {
                                                                      // another branch
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                          The method indexAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                          Open

                                                                      } else {
                                                                          $filter['item']['perspective'] = (int) $data['perspective_id'];
                                                                      }

                                                          ElseExpression

                                                          Since: 1.4.0

                                                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                          Example

                                                          class Foo
                                                          {
                                                              public function bar($flag)
                                                              {
                                                                  if ($flag) {
                                                                      // one branch
                                                                  } else {
                                                                      // another branch
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                          The method indexAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                          Open

                                                                  } else {
                                                                      $limit = 1;
                                                                  }

                                                          ElseExpression

                                                          Since: 1.4.0

                                                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                          Example

                                                          class Foo
                                                          {
                                                              public function bar($flag)
                                                              {
                                                                  if ($flag) {
                                                                      // one branch
                                                                  } else {
                                                                      // another branch
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                          TODO found
                                                          Open

                                                                  $validationGroup = array_keys($data); // TODO: intersect with real keys

                                                          syntax error, unexpected 'CarOfDay' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
                                                          Open

                                                              private CarOfDay $carOfDay;

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                              public function __construct(
                                                                  AbstractRestHydrator $hydrator,
                                                                  PictureItem $pictureItem,
                                                                  DuplicateFinder $duplicateFinder,
                                                                  UserPicture $userPicture,
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 1 day to fix
                                                          module/Application/src/Service/SpecificationsService.php on lines 128..175

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 356.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                              public function normalizeAction()
                                                              {
                                                                  if (! $this->user()->enforce('global', 'moderate')) {
                                                                      return $this->forbiddenAction();
                                                                  }
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 7 hrs to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 1167..1201

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 225.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                              public function flopAction()
                                                              {
                                                                  if (! $this->user()->enforce('global', 'moderate')) {
                                                                      return $this->forbiddenAction();
                                                                  }
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 7 hrs to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 1126..1160

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 225.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                              public function randomPictureAction(): JsonModel
                                                              {
                                                                  $pictureRow = $this->picture->getRow([
                                                                      'status' => Picture::STATUS_ACCEPTED,
                                                                      'order'  => 'random',
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 4 hrs to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 280..306

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 180.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                              public function newPictureAction(): JsonModel
                                                              {
                                                                  $pictureRow = $this->picture->getRow([
                                                                      'status' => Picture::STATUS_ACCEPTED,
                                                                      'order'  => 'accept_datetime_desc',
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 4 hrs to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 248..274

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 180.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                                                  if ($previousStatusUserId !== (int) $user['id']) {
                                                                                      $prevUser = $this->userModel->getRow($previousStatusUserId);
                                                                                      if ($prevUser) {
                                                                                          $uri = $this->hostManager->getUriByLanguage($prevUser['language']);
                                                          
                                                          
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 2 hrs to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 908..921

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 125.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                                              if ($previousStatusUserId !== (int) $user['id']) {
                                                                                  $prevUser = $this->userModel->getRow($previousStatusUserId);
                                                                                  if ($prevUser) {
                                                                                      $uri = $this->hostManager->getUriByLanguage($prevUser['language']);
                                                          
                                                          
                                                          Severity: Major
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 2 hrs to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 973..986

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 125.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                                              $this->log(sprintf(
                                                                                  'Замена %s на %s отклонена',
                                                                                  htmlspecialchars($this->pic()->name($replacePicture, $this->language())),
                                                                                  htmlspecialchars($this->pic()->name($picture, $this->language()))
                                                                              ), [
                                                          Severity: Minor
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 30 mins to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 1429..1435

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 90.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                                  $this->log(sprintf(
                                                                      'Замена %s на %s',
                                                                      htmlspecialchars($this->pic()->name($replacePicture, $this->language())),
                                                                      htmlspecialchars($this->pic()->name($picture, $this->language()))
                                                                  ), [
                                                          Severity: Minor
                                                          Found in module/Application/src/Controller/Api/PictureController.php and 1 other location - About 30 mins to fix
                                                          module/Application/src/Controller/Api/PictureController.php on lines 797..803

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 90.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          Avoid excessively long variable names like $publicListInputFilter. Keep variable name length under 20.
                                                          Open

                                                              private InputFilter $publicListInputFilter;

                                                          LongVariable

                                                          Since: 0.2

                                                          Detects when a field, formal or local variable is declared with a long name.

                                                          Example

                                                          class Something {
                                                              protected $reallyLongIntName = -3; // VIOLATION - Field
                                                              public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                  $otherReallyLongName = -5; // VIOLATION - Local
                                                                  for ($interestingIntIndex = 0; // VIOLATION - For
                                                                       $interestingIntIndex < 10;
                                                                       $interestingIntIndex++ ) {
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/naming.html#longvariable

                                                          Avoid excessively long variable names like $publicListInputFilter. Keep variable name length under 20.
                                                          Open

                                                                  InputFilter $publicListInputFilter,

                                                          LongVariable

                                                          Since: 0.2

                                                          Detects when a field, formal or local variable is declared with a long name.

                                                          Example

                                                          class Something {
                                                              protected $reallyLongIntName = -3; // VIOLATION - Field
                                                              public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                  $otherReallyLongName = -5; // VIOLATION - Local
                                                                  for ($interestingIntIndex = 0; // VIOLATION - For
                                                                       $interestingIntIndex < 10;
                                                                       $interestingIntIndex++ ) {
                                                                  }
                                                              }
                                                          }

                                                          Source https://phpmd.org/rules/naming.html#longvariable

                                                          There are no issues that match your filters.

                                                          Category
                                                          Status