Sign upLogin

autowp/autowp

View on GitHub
Star
module/Application/src/Controller/Api/PictureControllerFactory.php

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Method __invoke has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke(containerinterface $container, $requestedName, ?array $options = null): PictureController
    {
        $hydrators = $container->get('HydratorManager');
        $filters   = $container->get('InputFilterManager');
        return new PictureController(
Severity: Minor
Found in module/Application/src/Controller/Api/PictureControllerFactory.php - About 1 hr to fix

    The class PictureControllerFactory has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.
    Open

    class PictureControllerFactory implements FactoryInterface
{
    /**
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     * @param string                $requestedName
    Severity: Minor
    Found in module/Application/src/Controller/Api/PictureControllerFactory.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Parameter $options is never used
    Open

        public function __invoke(containerinterface $container, $requestedName, ?array $options = null): PictureController
    Severity: Minor
    Found in module/Application/src/Controller/Api/PictureControllerFactory.php by phan

    Parameter $requestedName is never used
    Open

        public function __invoke(containerinterface $container, $requestedName, ?array $options = null): PictureController
    Severity: Minor
    Found in module/Application/src/Controller/Api/PictureControllerFactory.php by phan

    There are no issues that match your filters.

    Category
    Status