Function putAction
has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring. Open
public function putAction()
{
$user = $this->user()->get();
if (! $user) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method putAction
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function putAction()
{
$user = $this->user()->get();
if (! $user) {
File UserController.php
has 279 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace Application\Controller\Api;
use Application\Hydrator\Api\AbstractRestHydrator;
Method postPhotoAction
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postPhotoAction()
{
$user = $this->user()->get();
if (! $user) {
Method indexAction
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function indexAction()
{
$user = $this->user()->get();
$this->listInputFilter->setData($this->params()->fromQuery());
Method deletePhotoAction
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function deletePhotoAction()
{
$user = $this->user()->get();
$id = $this->params('id');
Method __construct
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
AbstractRestHydrator $hydrator,
InputFilter $itemInputFilter,
InputFilter $listInputFilter,
InputFilter $putInputFilter,
InputFilter $postPhotoInputFilter,
Avoid too many return
statements within this method. Open
return $this->forbiddenAction();
Avoid too many return
statements within this method. Open
return $this->forbiddenAction();
Avoid too many return
statements within this method. Open
return $response->setStatusCode(Response::STATUS_CODE_200);
Function deletePhotoAction
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function deletePhotoAction()
{
$user = $this->user()->get();
$id = $this->params('id');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function postPhotoAction
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function postPhotoAction()
{
$user = $this->user()->get();
if (! $user) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method putAction() has 100 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function putAction()
{
$user = $this->user()->get();
if (! $user) {
- Exclude checks
The method putAction() has an NPath complexity of 12960. The configured NPath complexity threshold is 200. Open
public function putAction()
{
$user = $this->user()->get();
if (! $user) {
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method putAction() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
public function putAction()
{
$user = $this->user()->get();
if (! $user) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using static access to class '\DateTimeZone' in method 'putAction'. Open
foreach (DateTimeZone::listAbbreviations() as $group) {
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
syntax error, unexpected 'AbstractRestHydrator' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open
private AbstractRestHydrator $hydrator;
- Exclude checks