Sign upLogin

autowp/autowp

View on GitHub
Star
module/Application/src/Hydrator/Api/PreviewPictureHydrator.php

Summary

Maintainability
A
1 hr
Test Coverage
F
48%

Function extract has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function extract($object, $context = null): array
    {
        if (! is_array($object) && ! $object instanceof ArrayAccess) {
            throw new Exception("Array expected. Given: " . gettype($object));
        }
Severity: Minor
Found in module/Application/src/Hydrator/Api/PreviewPictureHydrator.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method extract uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $result['thumb'] = null;
        }
Severity: Minor
Found in module/Application/src/Hydrator/Api/PreviewPictureHydrator.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Laminas\Stdlib\ArrayUtils' in method 'setOptions'.
Open

            $options = ArrayUtils::iteratorToArray($options);
Severity: Minor
Found in module/Application/src/Hydrator/Api/PreviewPictureHydrator.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private int $userId = 0;
Severity: Critical
Found in module/Application/src/Hydrator/Api/PreviewPictureHydrator.php by phan

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    public function setOptions($options): self
    {
        parent::setOptions($options);

        if ($options instanceof Traversable) {
Severity: Major
Found in module/Application/src/Hydrator/Api/PreviewPictureHydrator.php and 5 other locations - About 45 mins to fix
module/Application/src/Hydrator/Api/AttrUserValueHydrator.php on lines 50..67
module/Application/src/Hydrator/Api/ItemParentHydrator.php on lines 60..77
module/Application/src/Hydrator/Api/LogHydrator.php on lines 38..55
module/Application/src/Hydrator/Api/PictureItemHydrator.php on lines 53..70
module/Application/src/Hydrator/Api/UserHydrator.php on lines 78..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status