Function fetch
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
public function fetch($item, array $options = []): array
{
$pictures = [];
$usedIds = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fetch
has 89 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetch($item, array $options = []): array
{
$pictures = [];
$usedIds = [];
Method getPictureSelect
has 77 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getPictureSelect(int $itemId, array $options): Sql\Select
{
$defaults = [
'perspectiveGroup' => false,
'exclude' => [],
File PerspectivePictureFetcher.php
has 273 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace Application\Model;
use ArrayAccess;
Method getTotalPictures
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getTotalPictures(int $itemId, bool $onlyExactly): int
{
if (! $itemId) {
return 0;
}
Function getPictureSelect
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function getPictureSelect(int $itemId, array $options): Sql\Select
{
$defaults = [
'perspectiveGroup' => false,
'exclude' => [],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method fetch() has an NPath complexity of 4158. The configured NPath complexity threshold is 200. Open
public function fetch($item, array $options = []): array
{
$pictures = [];
$usedIds = [];
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method fetch() has 110 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function fetch($item, array $options = []): array
{
$pictures = [];
$usedIds = [];
- Exclude checks
The method fetch() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
public function fetch($item, array $options = []): array
{
$pictures = [];
$usedIds = [];
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method fetch uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$result[] = null;
$emptyPictures++;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getPictureSelect uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$select
->join('item_parent_cache', 'picture_item.item_id = item_parent_cache.item_id', [])
->join('item', 'picture_item.item_id = item.id', [])
->where(['item_parent_cache.parent_id' => $itemId]);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getTotalPictures uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$select
->columns(['count' => new Sql\Expression('COUNT(1)')])
->join('picture_item', 'pictures.id = picture_item.picture_id', [])
->join(
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method fetch uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$pictures[] = null;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method fetch uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$useLargeFormat = $totalPictures > 30;
$pPageId = $useLargeFormat ? 5 : 4;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
syntax error, unexpected 'Picture' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open
protected Picture $pictureModel;
- Exclude checks
Avoid excessively long variable names like $containsPerspectiveId. Keep variable name length under 20. Open
private int $containsPerspectiveId = 0;
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}