Sign upLogin

autowp/autowp

View on GitHub
Star
module/Application/src/Model/PictureItem.php

Summary

Maintainability
C
1 day
Test Coverage
F
50%

File PictureItem.php has 359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Application\Model;

use ArrayObject;
Severity: Minor
Found in module/Application/src/Model/PictureItem.php - About 4 hrs to fix

    The class PictureItem has an overall complexity of 63 which is very high. The configured complexity threshold is 50.
    Open

    class PictureItem
{
    public const
        PICTURE_CONTENT    = 1,
        PICTURE_AUTHOR     = 2,
    Severity: Minor
    Found in module/Application/src/Model/PictureItem.php by phpmd

    Method getData has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getData(array $options): array
    {
        $defaults = [
            'picture'      => null,
            'item'         => null,
    Severity: Minor
    Found in module/Application/src/Model/PictureItem.php - About 1 hr to fix

      Method setProperties has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function setProperties(int $pictureId, int $itemId, int $type, array $properties): void
    {
        $row = $this->getRow($pictureId, $itemId, $type);
        if (! $row) {
            return;
      Severity: Minor
      Found in module/Application/src/Model/PictureItem.php - About 1 hr to fix

        Method setPictureItems has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function setPictureItems(int $pictureId, int $type, array $itemIds): void
    {
        if (! $pictureId) {
            throw new InvalidArgumentException("Picture id is invalid");
        }
        Severity: Minor
        Found in module/Application/src/Model/PictureItem.php - About 1 hr to fix

          Function setProperties has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setProperties(int $pictureId, int $itemId, int $type, array $properties): void
    {
        $row = $this->getRow($pictureId, $itemId, $type);
        if (! $row) {
            return;
          Severity: Minor
          Found in module/Application/src/Model/PictureItem.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setPictureItems has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setPictureItems(int $pictureId, int $type, array $itemIds): void
    {
        if (! $pictureId) {
            throw new InvalidArgumentException("Picture id is invalid");
        }
          Severity: Minor
          Found in module/Application/src/Model/PictureItem.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getData(array $options): array
    {
        $defaults = [
            'picture'      => null,
            'item'         => null,
          Severity: Minor
          Found in module/Application/src/Model/PictureItem.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method setProperties uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                          } else {
                    $set = array_replace($set, [
                        'crop_left'   => null,
                        'crop_top'    => null,
                        'crop_width'  => null,
          Severity: Minor
          Found in module/Application/src/Model/PictureItem.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          syntax error, unexpected 'TableGateway' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
          Open

              private TableGateway $table;
          Severity: Critical
          Found in module/Application/src/Model/PictureItem.php by phan

          There are no issues that match your filters.

          Category
          Status