Sign upLogin

autowp/autowp

View on GitHub
Star
module/Application/src/PictureNameFormatter.php

Summary

Maintainability
A
1 hr
Test Coverage
B
80%

Function format has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function format($picture, string $language): string
    {
        if (isset($picture['name']) && $picture['name']) {
            return $picture['name'];
        }
Severity: Minor
Found in module/Application/src/PictureNameFormatter.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function formatHtml has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function formatHtml(array $picture, string $language): string
    {
        if (isset($picture['name']) && $picture['name']) {
            return $this->renderer->escapeHtml($picture['name']);
        }
Severity: Minor
Found in module/Application/src/PictureNameFormatter.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

syntax error, unexpected 'TranslatorInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private TranslatorInterface $translator;
Severity: Critical
Found in module/Application/src/PictureNameFormatter.php by phan

There are no issues that match your filters.

Category
Status