autowp/autowp

View on GitHub
module/Application/src/Telegram/Command/NewCommand.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method handle has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle($arguments)
    {
        if (! $arguments) {
            $this->replyWithMessage([
                'text' => "Plase, type brand name. For Example /new BMW",
Severity: Minor
Found in module/Application/src/Telegram/Command/NewCommand.php - About 1 hr to fix

    Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle($arguments)
        {
            if (! $arguments) {
                $this->replyWithMessage([
                    'text' => "Plase, type brand name. For Example /new BMW",
    Severity: Minor
    Found in module/Application/src/Telegram/Command/NewCommand.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $this->telegramItemTable->insert(array_replace($set, $primaryKey));
            }

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    syntax error, unexpected 'TableGateway' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
    Open

        private TableGateway $telegramItemTable;

    There are no issues that match your filters.

    Category
    Status