Sign upLogin

autowp/autowp

View on GitHub
Star
module/Application/test/Model/PictureTest.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method addPictureToItem has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addPictureToItem(int $itemId): int
    {
        $this->reset();

        $this->mockDuplicateFinder();
Severity: Minor
Found in module/Application/test/Model/PictureTest.php - About 1 hr to fix

    Avoid using static access to class '\ApplicationTest\Data' in method 'addPictureItem'.
    Open

            $request->getHeaders()->addHeader(Data::getAdminAuthHeader(
            $this->getApplicationServiceLocator()->get('Config')['keycloak']
        ));
    Severity: Minor
    Found in module/Application/test/Model/PictureTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\ApplicationTest\Data' in method 'addPictureToItem'.
    Open

                ->addHeader(Data::getAdminAuthHeader(
                $this->getApplicationServiceLocator()->get('Config')['keycloak']
            ))
    Severity: Minor
    Found in module/Application/test/Model/PictureTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\ApplicationTest\Data' in method 'createItem'.
    Open

            $request->getHeaders()->addHeader(Data::getAdminAuthHeader(
            $this->getApplicationServiceLocator()->get('Config')['keycloak']
        ));
    Severity: Minor
    Found in module/Application/test/Model/PictureTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
    Open

        protected string $applicationConfigPath = __DIR__ . '/../../../../config/application.config.php';
    Severity: Critical
    Found in module/Application/test/Model/PictureTest.php by phan

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function testAuthorAndVehiclePictureFilenamePattern(): void
    {
        $vehicleId = $this->createItem([
            'item_type_id' => 1,
            'name'         => 'Toyota Corolla',
    Severity: Major
    Found in module/Application/test/Model/PictureTest.php and 2 other locations - About 1 hr to fix
    module/Application/test/Model/PictureTest.php on lines 211..228
    module/Application/test/Model/PictureTest.php on lines 249..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function testPersonAndCopyrightPictureFilenamePattern(): void
    {
        $personId  = $this->createItem([
            'item_type_id' => 8,
            'name'         => 'A.S. Pushkin',
    Severity: Major
    Found in module/Application/test/Model/PictureTest.php and 2 other locations - About 1 hr to fix
    module/Application/test/Model/PictureTest.php on lines 230..247
    module/Application/test/Model/PictureTest.php on lines 249..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        private function mockDuplicateFinder(): void
    {
        $serviceManager = $this->getApplicationServiceLocator();

        $tables = $serviceManager->get('TableManager');
    Severity: Major
    Found in module/Application/test/Model/PictureTest.php and 4 other locations - About 1 hr to fix
    module/Application/test/Controller/Api/InboxControllerTest.php on lines 29..46
    module/Application/test/Controller/Api/ItemControllerTest.php on lines 164..181
    module/Application/test/Controller/Api/PictureControllerTest.php on lines 29..46
    module/Application/test/Controller/Api/PictureModerVoteControllerTest.php on lines 28..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function testPersonAndVehiclePictureFilenamePattern(): void
    {
        $vehicleId = $this->createItem([
            'item_type_id' => 1,
            'name'         => 'Toyota Corolla',
    Severity: Major
    Found in module/Application/test/Model/PictureTest.php and 2 other locations - About 1 hr to fix
    module/Application/test/Model/PictureTest.php on lines 211..228
    module/Application/test/Model/PictureTest.php on lines 230..247

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long variable names like $applicationConfigPath. Keep variable name length under 20.
    Open

        protected string $applicationConfigPath = __DIR__ . '/../../../../config/application.config.php';
    Severity: Minor
    Found in module/Application/test/Model/PictureTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status