Sign upLogin

autowp/autowp

View on GitHub
Star
module/Commons/src/Db/Table/Row.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\DateTime' in method 'getDateTimeByColumnType'.
Open

        return DateTime::createFromFormat($format, $value, $timezone);
Severity: Minor
Found in module/Commons/src/Db/Table/Row.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

TODO found
Open

        //TODO: extract constant
Severity: Minor
Found in module/Commons/src/Db/Table/Row.php by fixme

Possibly zero references to public method \Autowp\Commons\Db\Table\Row::getDateTimeByColumnType()
Open

    public static function getDateTimeByColumnType(string $type, $value): ?DateTime
Severity: Minor
Found in module/Commons/src/Db/Table/Row.php by phan

Possibly zero references to class \Autowp\Commons\Db\Table\Row
Open

class Row
Severity: Minor
Found in module/Commons/src/Db/Table/Row.php by phan

There are no issues that match your filters.

Category
Status