Sign upLogin

autowp/autowp

View on GitHub
Star
module/User/src/Model/User.php

Summary

Maintainability
C
1 day
Test Coverage
C
76%

Method getSelect has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getSelect($options): Sql\Select
    {
        $options = is_array($options) ? $options : ['id' => $options];

        $defaults = [
Severity: Major
Found in module/User/src/Model/User.php - About 2 hrs to fix

    Function getSelect has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getSelect($options): Sql\Select
    {
        $options = is_array($options) ? $options : ['id' => $options];

        $defaults = [
    Severity: Minor
    Found in module/User/src/Model/User.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function registerVisit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function registerVisit(int $userId, Request $request): void
    {
        $user = $this->getRow($userId);
        if (! $user) {
            return;
    Severity: Minor
    Found in module/User/src/Model/User.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function applyIdFilter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function applyIdFilter(Sql\Select $select, $value, string $id): void
    {
        if (is_array($value)) {
            $value = array_values($value);
    Severity: Minor
    Found in module/User/src/Model/User.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method getSelect() has an NPath complexity of 8192. The configured NPath complexity threshold is 200.
    Open

        private function getSelect($options): Sql\Select
    {
        $options = is_array($options) ? $options : ['id' => $options];

        $defaults = [
    Severity: Minor
    Found in module/User/src/Model/User.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method getSelect() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

        private function getSelect($options): Sql\Select
    {
        $options = is_array($options) ? $options : ['id' => $options];

        $defaults = [
    Severity: Minor
    Found in module/User/src/Model/User.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The class User has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class User
{
    public const MIN_NAME     = 2;
    public const MAX_NAME     = 50;
    public const MIN_PASSWORD = 6;
    Severity: Minor
    Found in module/User/src/Model/User.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid using static access to class '\Autowp\Commons\Db\Table\Row' in method 'getMessagingInterval'.
    Open

            $date = Row::getDateTimeByColumnType('timestamp', $row['reg_date']);
    Severity: Minor
    Found in module/User/src/Model/User.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Autowp\Commons\Db\Table\Row' in method 'getNextMessageTime'.
    Open

            $lastMessageTime = Row::getDateTimeByColumnType('timestamp', $row['last_message_time']);
    Severity: Minor
    Found in module/User/src/Model/User.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Autowp\Commons\Db\Table\Row' in method 'registerVisit'.
    Open

            $lastOnline     = Row::getDateTimeByColumnType('timestamp', $user['last_online']);
    Severity: Minor
    Found in module/User/src/Model/User.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    syntax error, unexpected 'TableGateway' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
    Open

        private TableGateway $table;
    Severity: Critical
    Found in module/User/src/Model/User.php by phan

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        private function applyIdFilter(Sql\Select $select, $value, string $id): void
    {
        if (is_array($value)) {
            $value = array_values($value);
    Severity: Major
    Found in module/User/src/Model/User.php and 2 other locations - About 4 hrs to fix
    module/Application/src/Model/Item.php on lines 1006..1030
    module/Application/src/Model/Picture.php on lines 90..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 176.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            $defaults = [
            'id'               => null,
            'identity'         => null,
            'not_deleted'      => null,
            'search'           => null,
    Severity: Major
    Found in module/User/src/Model/User.php and 2 other locations - About 1 hr to fix
    module/Application/src/Model/Item.php on lines 1037..1050
    module/Application/src/Model/Picture.php on lines 235..248

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function isExists(array $options): bool
    {
        $select = $this->getSelect($options);
        $select->reset($select::COLUMNS);
        $select->reset($select::ORDER);
    Severity: Major
    Found in module/User/src/Model/User.php and 2 other locations - About 45 mins to fix
    module/Application/src/Model/Item.php on lines 1580..1590
    module/Application/src/Model/Picture.php on lines 881..891

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status