Sign upLogin

autowp/autowp

View on GitHub
Star
module/User/src/Service/OAuth.php

Summary

Maintainability
B
6 hrs
Test Coverage
B
80%

Function getUserID has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function getUserID(): int
    {
        if (! isset($this->userId)) {
            $header = $this->request->getHeader('Authorization');
            if (! $header) {
Severity: Minor
Found in module/User/src/Service/OAuth.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getUserID has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getUserID(): int
    {
        if (! isset($this->userId)) {
            $header = $this->request->getHeader('Authorization');
            if (! $header) {
Severity: Minor
Found in module/User/src/Service/OAuth.php - About 1 hr to fix

    Method ensureUserImported has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function ensureUserImported(object $claims)
    {
        $locale = isset($claims->locale) ? mb_strtolower($claims->locale) : '';
        if (! isset($this->hosts[$locale])) {
            $locale = 'en';
    Severity: Minor
    Found in module/User/src/Service/OAuth.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Request $request,
        array $keycloakConfig,
        StorageInterface $cache,
        array $hosts,
        TableGateway $userTable
      Severity: Minor
      Found in module/User/src/Service/OAuth.php - About 35 mins to fix

        Function ensureUserImported has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function ensureUserImported(object $claims)
    {
        $locale = isset($claims->locale) ? mb_strtolower($claims->locale) : '';
        if (! isset($this->hosts[$locale])) {
            $locale = 'en';
        Severity: Minor
        Found in module/User/src/Service/OAuth.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return 0;
        Severity: Major
        Found in module/User/src/Service/OAuth.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this->userId;
          Severity: Major
          Found in module/User/src/Service/OAuth.php - About 30 mins to fix

            Avoid using static access to class '\Firebase\JWT\JWT' in method 'getUserID'.
            Open

                            $decoded = JWT::decode($parts[1], $key);
            Severity: Minor
            Found in module/User/src/Service/OAuth.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            syntax error, unexpected 'Request' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
            Open

                private Request $request;
            Severity: Critical
            Found in module/User/src/Service/OAuth.php by phan

            There are no issues that match your filters.

            Category
            Status