avocado-framework/avocado

View on GitHub
avocado/utils/asset.py

Summary

Maintainability
C
1 day
Test Coverage
B
88%

File asset.py has 553 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
Severity: Major
Found in avocado/utils/asset.py - About 1 day to fix

    Function _get_relative_dir has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _get_relative_dir(self):
            """
            When an asset name is not an URI, and:
              1. it also has a hash;
              2. or it has multiple locations;
    Severity: Minor
    Found in avocado/utils/asset.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in avocado/utils/asset.py - About 50 mins to fix

      Function get_asset_by_name has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get_asset_by_name(cls, name, cache_dirs, expire=None, asset_hash=None):
      Severity: Minor
      Found in avocado/utils/asset.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status