Sign upLogin

avocado-framework/avocado

View on GitHub
Star
avocado/utils/kernel.py

Summary

Maintainability
A
25 mins
Test Coverage
F
45%

Function call with shell=True parameter identified, possible security issue.
Open

                process.run(" ".join(cmd), shell=True)
Severity: Minor
Found in avocado/utils/kernel.py by bandit

Function call with shell=True parameter identified, possible security issue.
Open

            process.run(f"dpkg -i {self.work_dir}/*.deb", shell=True, sudo=True)
Severity: Minor
Found in avocado/utils/kernel.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert os_version > version, "Old kernel"
Severity: Info
Found in avocado/utils/kernel.py by bandit

Function configure has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def configure(self, targets=("defconfig"), extra_configs=None):
        """
        Configure/prepare kernel source to build.

        :param targets: configuration targets. Default is 'defconfig'.
Severity: Minor
Found in avocado/utils/kernel.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status